Skip to content

fix(core): reject ignored explicit-client options for OpenAIProvider - #4497

Merged
seratch merged 2 commits into
openai:mainfrom
sylvesterkaczmarek:fix/openai-provider-client-options
Aug 17, 2026
Merged

fix(core): reject ignored explicit-client options for OpenAIProvider#4497
seratch merged 2 commits into
openai:mainfrom
sylvesterkaczmarek:fix/openai-provider-client-options

Conversation

@sylvesterkaczmarek

Copy link
Copy Markdown
Contributor

Summary

  • reject organization and project when openai_client is supplied
  • align them with existing rejection of api_key, base_url, and websocket_base_url
  • prevent documented client-construction options from being silently ignored

When an explicit AsyncOpenAI client is supplied, client-construction options cannot affect that client. Failing fast avoids configuration that appears to be applied but is actually discarded.

Test plan

  • added focused regression coverage in tests/test_openai_provider_client_options.py
  • GitHub Actions

Issue number

N/A

@sylvesterkaczmarek
sylvesterkaczmarek marked this pull request as ready for review August 17, 2026 21:08
@seratch seratch changed the title fix(models): reject ignored explicit-client options fix(core): reject ignored explicit-client options Aug 17, 2026
@seratch seratch added this to the 0.21.x milestone Aug 17, 2026
@seratch seratch changed the title fix(core): reject ignored explicit-client options fix(core): reject ignored explicit-client options for OpenAIProvider Aug 17, 2026
@seratch
seratch merged commit a77d37e into openai:main Aug 17, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants