fix(prompt): omit tool_choice when prompt manages built-in tools#2464
Merged
seratch merged 3 commits intoopenai:mainfrom Feb 11, 2026
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8e93bffd17
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
seratch
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue where prompt-managed built-in tools can fail with:
Tool choice 'web_search_preview' not found in 'tools' parameter.This happens when a prompt is supplied, local tools are empty, and a
tool_choicevalue is still forwarded in the request.What changed
OpenAIResponsesModel._fetch_response(...), when prompt mode is active and localtoolsare omitted,tool_choiceis also omitted.tool_choiceis omitted in this prompt-managed-tools path.Why this is safe
Validation
uv run --with ruff ruff check src/agents/models/openai_responses.py tests/test_openai_responses.pyuv run --with mypy --with socksio mypy src/agents/models/openai_responses.py tests/test_openai_responses.pyuv run --with pytest --with socksio pytest -q tests/test_openai_responses.py