Skip to content

Conversation

@owenlin0
Copy link
Contributor

@owenlin0 owenlin0 commented Nov 21, 2025

Add thread_id and turn_id to item/started, item/completed, and error notifications. Otherwise the client will have a hard time knowing which thread & turn (if multiple threads are running in parallel) a new item/error is for.

Also add thread_id to turn/started and turn/completed.

@owenlin0 owenlin0 changed the title [app-server] feat: add thread_id and turn_id to item notifications [app-server] feat: add thread_id and turn_id to item and error notifications Nov 21, 2025
@owenlin0 owenlin0 marked this pull request as ready for review November 21, 2025 23:43
@celia-oai
Copy link
Contributor

seems that the easiest way to populate applicable to all events:
conversation_id -> thread_id
event_id -> turn_id (defined here:https://github.com/openai/codex/blob/dev/cc/usage/codex-rs/core/src/codex.rs#L788)

@owenlin0 owenlin0 force-pushed the owen/add_thread_id_and_turn_id_to_item_notifs branch from f7ab7a5 to f7f5fcb Compare November 25, 2025 04:29
@owenlin0 owenlin0 force-pushed the owen/add_thread_id_and_turn_id_to_item_notifs branch from f7f5fcb to 81385a1 Compare November 25, 2025 04:30
@owenlin0 owenlin0 requested a review from jif-oai November 25, 2025 05:00
@owenlin0 owenlin0 merged commit 157a16c into main Nov 25, 2025
26 checks passed
@owenlin0 owenlin0 deleted the owen/add_thread_id_and_turn_id_to_item_notifs branch November 25, 2025 16:05
@github-actions github-actions bot locked and limited conversation to collaborators Nov 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants