Fix MIME types for path-backed feedback attachments#30796
Open
btraut-openai wants to merge 2 commits into
Open
Fix MIME types for path-backed feedback attachments#30796btraut-openai wants to merge 2 commits into
btraut-openai wants to merge 2 commits into
Conversation
Contributor
Author
|
@codex review |
Contributor
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Path-backed feedback attachments were always labeled
text/plain, even when the attached file was a gzip archive. Sentry consumers could therefore UTF-8-decode a valid Codex Desktop log bundle and corrupt the transferred bytes before anyone inspected it. Desktop already creates a valid archive and sends its path throughfeedback/upload; the bad metadata was assigned later by app-server's feedback upload path.Slack investigation: https://openai.slack.com/archives/C09NZ54M4KY/p1782867266569699
What changed
Path-backed feedback attachments now derive their MIME type from the final uploaded filename. Gzip files use
application/gzip, known text formats remain text, and unrecognized files use the safeapplication/octet-streamfallback. Attachment filenames and bytes are unchanged.How it works
.jsonlrollouts remaintext/plain, while other known formats use the repository's existingmime_guessmapping.application/octet-streaminstead of being treated as UTF-8 text.feedback/uploadstill accepts the same path list, so Desktop, generated protocol surfaces, and remote-host minimums do not change.Verification
Added focused coverage for gzip MIME, unknown binary fallback,
.jsonltext handling, and exact filename/byte preservation. Ran the completecodex-feedbacktest suite (9 tests), crate-scoped Clippy, Rust formatting, Bazel lock refresh, and diff checks successfully.