Skip to content

bug(core) websockets metadata equivalence issue#30770

Draft
dylan-hurd-oai wants to merge 1 commit into
mainfrom
dh--client--websocket-incremental-fix
Draft

bug(core) websockets metadata equivalence issue#30770
dylan-hurd-oai wants to merge 1 commit into
mainfrom
dh--client--websocket-incremental-fix

Conversation

@dylan-hurd-oai

@dylan-hurd-oai dylan-hurd-oai commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

Summary

This test, as currently configured, is designed to fail, highlighting an issue with unnecessary matching on metadata in the websocket client.

When run, it fails with on the third request because it does not match the previous request id:

thread 'suite::client_websockets::responses_websocket_v2_incremental_requests_are_reused_across_turns' (40373099) panicked at core/tests/suite/client_websockets.rs:1053:5:
assertion failed: `(left == right)`

Diff < left / right > :
<None
>Some(
>    "resp-2",
>)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant