perf(core): avoid duplicate first-turn filesystem discovery#30670
Draft
apanasenko-oai wants to merge 1 commit into
Draft
perf(core): avoid duplicate first-turn filesystem discovery#30670apanasenko-oai wants to merge 1 commit into
apanasenko-oai wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove avoidable remote filesystem work from first-turn startup.
This is the startup-filesystem slice split out of #30632.
Measured effect
The baseline turn spent 438.6 ms in
turn_diff_display_rootsbefore the first model request.Post-change no-tool traces contain no display-root span, proving that the entire operation is absent unless a patch diff actually needs it.
Validation
just test -p codex-core-skills repo_skill_rootspassed 2 tests.just test -p codex-core display_roots_are_initialized_only_when_suppliedpassed.just fmtpassed, with an unrelated justfile rewrite discarded.just bazel-lock-updatecompleted without changingMODULE.bazel.lock.