Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 06e71ab184
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if !config | ||
| .config_layer_stack | ||
| .requirements() | ||
| .allow_plugin_sharing() |
There was a problem hiding this comment.
Preserve the legacy plugin_sharing disable
When a user or managed config already has [features]\nplugin_sharing = false but no new allow_plugin_sharing = false requirements entry, this replacement no longer blocks plugin/share/save: the PluginSharing feature key was removed from FEATURES, so that config key is now ignored, and allow_plugin_sharing() defaults to true when requirements are unset. That silently re-enables remote sharing for existing installations that had disabled the stable feature flag; please keep a compatibility path or combine the old feature value with the new requirements gate during migration.
Useful? React with 👍 / 👎.
Adds a top-level allow_plugin_sharing requirements field that defaults to enabled when unset, exposes it through configRequirements/read, and uses it to gate shared-with-me plugin listing and plugin share saves. Removes the old plugin_sharing feature flag