Skip to content

feat: Let requirements disable plugin sharing#22465

Open
xl-openai wants to merge 1 commit into
mainfrom
xl/req
Open

feat: Let requirements disable plugin sharing#22465
xl-openai wants to merge 1 commit into
mainfrom
xl/req

Conversation

@xl-openai
Copy link
Copy Markdown
Collaborator

Adds a top-level allow_plugin_sharing requirements field that defaults to enabled when unset, exposes it through configRequirements/read, and uses it to gate shared-with-me plugin listing and plugin share saves. Removes the old plugin_sharing feature flag

@xl-openai xl-openai requested a review from a team as a code owner May 13, 2026 08:59
Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 06e71ab184

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +855 to +858
if !config
.config_layer_stack
.requirements()
.allow_plugin_sharing()
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve the legacy plugin_sharing disable

When a user or managed config already has [features]\nplugin_sharing = false but no new allow_plugin_sharing = false requirements entry, this replacement no longer blocks plugin/share/save: the PluginSharing feature key was removed from FEATURES, so that config key is now ignored, and allow_plugin_sharing() defaults to true when requirements are unset. That silently re-enables remote sharing for existing installations that had disabled the stable feature flag; please keep a compatibility path or combine the old feature value with the new requirements gate during migration.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant