feat: Move plugin sharing control into plugin config#22430
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cf6f50d022
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| RemotePlugin, | ||
| /// Enable remote plugin sharing flows. | ||
| PluginSharing, | ||
| /// Show the startup prompt for migrating external agent config into Codex. |
There was a problem hiding this comment.
When an existing user or managed config still contains [features] plugin_sharing = false, removing plugin_sharing from the feature registry makes that key unknown and ignored by Features::apply_map, while Config::plugins_allow_sharing() now defaults to allowing sharing unless [plugins].allow_sharing is explicitly false. In those installations, upgrading silently re-enables plugin/list SharedWithMe and plugin/share/save flows that were previously disabled, so the old stable key needs to be honored during migration or mapped into the new plugin config gate.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
it's ok this flag is not used in any released version.
sayan-oai
left a comment
sayan-oai
left a comment
There was a problem hiding this comment.
some cleanup needed as we discussed offline. PluginsConfig and PluginsRequirementToml types dont seem great as its another wrapping layer, but i dont see an obvious alternative
2 participants
[plugins] allow_sharing, defaulting to enabled while preserving existing[plugins."<name>"]entries.