Skip to content

Use plugin/list to get list of plugins for mentions#22375

Merged
canvrno-oai merged 3 commits into
mainfrom
canvrno/mentions_plugins_list
May 13, 2026
Merged

Use plugin/list to get list of plugins for mentions#22375
canvrno-oai merged 3 commits into
mainfrom
canvrno/mentions_plugins_list

Conversation

@canvrno-oai
Copy link
Copy Markdown
Contributor

@canvrno-oai canvrno-oai commented May 12, 2026

This switches TUI plugin mentions to use app-server plugin/list for plugin inventory and metadata instead of PluginManager, while keeping the same mention-eligibility filters as before.

Same filters as before:

  • Only plugins in the current config / cwd scope.
  • Only installed and enabled plugins.
  • Only plugins that actually expose a capability, meaning at least one skill, MCP server, or app connector.
  • Uses plugin/list for the mention names/descriptions

@canvrno-oai canvrno-oai marked this pull request as ready for review May 12, 2026 21:06
@canvrno-oai
Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown
Contributor

Codex Review: Didn't find any major issues. Delightful!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Copy Markdown
Contributor

@fcoury-oai fcoury-oai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a smoke test with a workspace where plugin/list returned a name, while the installed cache copy used different metadata and only provided the skill capability and it worked as expected.

One this wasn't clear to me: is this supposed to be a gradual migration to use app-server? What happens if we run this connected to an app-server right now? Is there a mismatch between the list and the individual plugin information?

The code looks good, I just need to understand the intention behind this PR 🙂

@canvrno-oai
Copy link
Copy Markdown
Contributor Author

@fcoury-oai The main issue this fixes is that the older TUI-local PluginsManager path cannot correctly surface some cloud/remote plugins, so mentions now use plugin/list for the plugin inventory and display metadata. This will be relevant to some of the upcoming changes to plugins, so this is preemptive to avoid missing plugins in the mentions menu once those changes are live.

There is still a temporary split: plugin/list does not expose the capability summary mentions need, so we still use codex_plugin::PluginCapabilitySummary from the local load path to decide whether a plugin has enough capabilities to show in mentions. In the normal local app-server case this works as expected. In a true remote app-server case, remote-only plugins without a matching local capability summary would be omitted from @/$ mentions, so we will need to follow up on the app-server side.

@canvrno-oai canvrno-oai requested a review from fcoury-oai May 13, 2026 18:03
Copy link
Copy Markdown
Contributor

@fcoury-oai fcoury-oai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fcoury-oai The main issue this fixes is that the older TUI-local PluginsManager path cannot correctly surface some cloud/remote plugins, so mentions now use plugin/list for the plugin inventory and display metadata. This will be relevant to some of the upcoming changes to plugins, so this is preemptive to avoid missing plugins in the mentions menu once those changes are live.

I understand now, thank you! Approved.

@canvrno-oai canvrno-oai merged commit 16592f5 into main May 13, 2026
27 checks passed
@canvrno-oai canvrno-oai deleted the canvrno/mentions_plugins_list branch May 13, 2026 21:11
@github-actions github-actions Bot locked and limited conversation to collaborators May 13, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants