ci: test skill powered v8 upgrade#22374
Conversation
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Produce explicitly named sandbox release pairs alongside the current compatibility artifacts, and validate staged sandbox outputs before publication across the supported artifact targets. Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Keep non-Windows rusty-v8 consumers on the resolved 147.4.0 source-built graph. Avoid mixing LLVM's default libc++ headers into rusty-v8's custom libc++ build, propagate that configuration to external C++ deps, and export the musl-specific libc++ define through the shared header target. Also make checksum validation follow the remaining prebuilt asset version while the source-build migration is in progress. Co-authored-by: Codex <noreply@openai.com>
Add the `crdtp_binding.cc` source and CRDTP headers to the 147 Bazel V8 binding target so Windows GNU builds provide the symbols required by the `v8::crdtp` Rust APIs. Add a regression test that exercises CRDTP JSON conversion and dispatchable message parsing.
Fetch the published per-target checksum asset alongside the musl archive and binding so Cargo musl jobs keep working without re-expanding the MODULE.bazel checksum manifest contract.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a329661584
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| + "@abseil-cpp+", | ||
| + "@v8++http_archive+highway", | ||
| + "@v8++http_archive+simdutf", |
There was a problem hiding this comment.
When --config=rusty-v8-upstream-libcxx builds Abseil/highway/simdutf, Bazel's native.repository_name() returns the canonical repo name without leading at-signs, so these entries never match the value checked on line 37. That means the wrapper never adds the custom libc++ copts/deps to the external C++ deps this patch is meant to handle, leaving the V8 artifact build to compile them with the default toolchain headers/runtime instead of the bundled Chromium libc++ setup.
Useful? React with 👍 / 👎.
cconger
force-pushed
the
cconger/update-rusty-v8-12d7ef1d
branch
from
ceb779b to
a329661
Compare
Ensure V8's Bazel snapshot rule forwards the transitioned target architecture so cross-target Darwin builds do not emit host-architecture embedded assembly. Co-authored-by: Codex <noreply@openai.com>
1 participant
Updating to a unreleased version of rusty-v8 using the skill, this is to test that CI passes.
do not merge