windows-sandbox: fail elevated setup when firewall policy is ineffective#22353
Open
iceweasel-oai wants to merge 1 commit into
Open
windows-sandbox: fail elevated setup when firewall policy is ineffective#22353iceweasel-oai wants to merge 1 commit into
iceweasel-oai wants to merge 1 commit into
Conversation
viyatb-oai
approved these changes
May 12, 2026
evawong-oai
approved these changes
May 12, 2026
Contributor
There was a problem hiding this comment.
Validated on AWS Windows VM against head ae1ef5c.
- Fetched PR 22353 on EC2AMAZ 6M6C40J and confirmed HEAD matched.
- Ran cargo test for codex windows sandbox setup. Result 7 passed and 0 failed, including the LocalPolicyModifyState cases and firewall COM scope cases.
- Built codex cli and codex windows sandbox bins successfully in the prior pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Elevated Windows sandbox setup currently assumes that the firewall rules it writes will take effect. On managed Windows hosts, local firewall policy changes can be ignored or only partially apply across the active profiles, which means setup can appear to succeed without providing the expected network isolation.
What changed
INetFwPolicy2::LocalPolicyModifyStatebefore configuring the elevated sandbox firewall rules.helper_firewall_policy_ineffectivesetup error code so support and IT-facing diagnostics can distinguish it from COM access failures.Testing
cargo test -p codex-windows-sandbox --bin codex-windows-sandbox-setup