Expose network approval parent item ids in app-server#15595
Open
charley-oai wants to merge 4 commits intocc/network-approval-parent-tool-item-corefrom
Open
Expose network approval parent item ids in app-server#15595charley-oai wants to merge 4 commits intocc/network-approval-parent-tool-item-corefrom
charley-oai wants to merge 4 commits intocc/network-approval-parent-tool-item-corefrom
Conversation
Thread a typed parent tool item id through guardian assessment events and legacy app-server guardian review notifications for network approvals. Co-authored-by: Codex <noreply@openai.com>
Keep `targetItemId` as a deprecated compatibility alias while emitting the clearer `reviewId` field on legacy guardian approval review notifications.\n\nCo-authored-by: Codex <noreply@openai.com>
Populate parent tool item ids for direct guardian-reviewed tool actions while preserving distinct network approval review ids. Co-authored-by: Codex <noreply@openai.com>
charley-oai
force-pushed
the
cc/network-approval-parent-tool-item-app-server
branch
from
0d60aaa to
e2494ae
Compare
Co-authored-by: Codex <noreply@openai.com>
Collaborator
Author
|
@codex review |
Contributor
|
Codex Review: Didn't find any major issues. What shall we delve into next? ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parentToolItemIdto legacy guardian review notificationsreviewIdas the clearer stable guardian review identifier while keepingtargetItemIdas a deprecated aliastui_app_serverto consume the typed parent/review idsparentToolItemIdfor direct tool reviews as well, so downstream consumers can treat it as consistently available except when network attribution is genuinely unavailableStack
Why This PR Exists
Once core can attribute blocked network requests to the correct parent tool item, app-server needs to expose that relationship in a typed way. This branch keeps the legacy notification surface compatible while making the review id and parent tool item id distinct.
Verification
cargo test -p codex-app-server-protocolcargo test -p codex-protocolcodex-tui-app-servervalidation was started during the split, but I deferred the rest to PR CI once the local runs stopped providing clear incremental signal