Skip to content

Extract landlock helpers into codex-sandboxing#15592

Merged
pakrym-oai merged 2 commits intomainfrom
pakrym/sandboxing-crate-step-1-landlock
Mar 24, 2026
Merged

Extract landlock helpers into codex-sandboxing#15592
pakrym-oai merged 2 commits intomainfrom
pakrym/sandboxing-crate-step-1-landlock

Conversation

@pakrym-oai
Copy link
Collaborator

@pakrym-oai pakrym-oai commented Mar 24, 2026

Summary

  • add a new codex-sandboxing crate for sandboxing extraction work
  • move the pure Linux sandbox argv builders and their unit tests out of codex-core
  • keep core::landlock as the spawn wrapper and update direct callers to use codex_sandboxing::landlock

Testing

  • cargo test -p codex-sandboxing
  • cargo test -p codex-core landlock
  • cargo test -p codex-cli debug_sandbox
  • just argument-comment-lint

Notes

  • this is step 1 of the move plan aimed at minimizing per-PR diffs
  • no re-exports or no-op proxy methods were added

@@ -0,0 +1 @@
pub mod landlock;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we cfg gate this to Linux?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will take as a followup

@pakrym-oai pakrym-oai merged commit 2227248 into main Mar 24, 2026
84 of 98 checks passed
@pakrym-oai pakrym-oai deleted the pakrym/sandboxing-crate-step-1-landlock branch March 24, 2026 03:56
@github-actions github-actions bot locked and limited conversation to collaborators Mar 24, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants