[codex] add workspace snapshot turn metadata#15574
Draft
Conversation
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
git_workspace_snapshotfeature flagworkspace_snapshot_commit_hashto async turn metadata when the feature is enabledplan.mdfrom the worktree branchWhy
Codex currently records
HEADandhas_changes, but it does not expose a stable identifier for the actual dirty workspace state. This change adds that identifier without moving the work onto the session-start path.User Impact
When
git_workspace_snapshotis enabled, turn metadata includes aworkspace_snapshot_commit_hashthat equalsHEADfor a clean repo and a synthetic snapshot commit hash for a dirty repo.Validation
cargo test -p codex-featuresRUSTY_V8_ARCHIVE=/Users/kevin.liu/code/codex/codex-rs/target/debug/gn_out/obj/librusty_v8.a cargo test -p codex-core --lib workspace_snapshot_commitRUSTY_V8_ARCHIVE=/Users/kevin.liu/code/codex/codex-rs/target/debug/gn_out/obj/librusty_v8.a cargo test -p codex-core --test responses_headers responses_stream_includes_workspace_snapshot_commit_hash_when_feature_enabled -- --exactRUSTY_V8_ARCHIVE=/Users/kevin.liu/code/codex/codex-rs/target/debug/gn_out/obj/librusty_v8.a cargo test -p codex-core config::schema::tests::config_schema_matches_fixture -- --exactRUSTY_V8_ARCHIVE=/Users/kevin.liu/code/codex/codex-rs/target/debug/gn_out/obj/librusty_v8.a cargo test -p codex-corearc_monitor, plugin sync, andjs_repltests; the snapshot-related tests passedRUSTY_V8_ARCHIVE=/Users/kevin.liu/code/codex/codex-rs/target/debug/gn_out/obj/librusty_v8.a just fix -p codex-corejust fmtNotes
just argument-comment-lintcould not run in this checkout becausetools/argument-comment-lint/run-prebuilt-linter.shis missing.