tui: Deflake resume_startup_does_not_consume_model_availability_nux_count#15566
Open
euroelessar wants to merge 1 commit intomainfrom
Open
Conversation
euroelessar
changed the title
euroelessar
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deflaked it in both copies by removing the Ctrl-C/exit-code dependency from the harness. The test now waits for resume startup to produce initial TUI output, then terminates the PTY and checks only the config side effect it actually cares about, so CI won’t fail on the incidental exit 1 path from injected interrupts.
Testing
cd codex-rs && cargo test -p codex-tui resume_startup_does_not_consume_model_availability_nux_countcd codex-rs && cargo test -p codex-tui-app-server resume_startup_does_not_consume_model_availability_nux_countcd codex-rs && just fmtcd codex-rs && just fix -p codex-tui