Move git utilities into a dedicated crate by aibrahim-oai · Pull Request #15564 · openai/codex

aibrahim-oai · 2026-03-23T21:51:38Z

create codex-git-utils and move the shared git helpers into it with file moves preserved for diff readability
move the GitInfo helpers out of core so stacked rollout work can depend on the shared crate without carrying its own git info module

aibrahim-oai · 2026-03-23T22:00:37Z

@codex review this

chatgpt-codex-connector · 2026-03-23T22:05:54Z

Codex Review: Didn't find any major issues. Keep them coming!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Co-authored-by: Codex <noreply@openai.com>

aibrahim-oai · 2026-03-24T03:03:13Z

@codex review this

aibrahim-oai · 2026-03-24T03:05:48Z

@codex review this

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 05fdd24124

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-03-24T03:10:20Z

codex-rs/Cargo.lock

 [[package]]
 name = "tar"
-version = "0.4.45"
+version = "0.4.44"


Upgrade tar to a non-vulnerable version

The lockfile downgrades tar to 0.4.44, and this same change adds cargo-deny ignores for RUSTSEC-2026-0067/0068 (codex-rs/deny.toml:79-80). That reintroduces known archive parsing/extraction vulnerabilities while suppressing automated detection. Keep tar on a patched release (>=0.4.45) and avoid suppressing these advisories in this refactor.

Useful? React with 👍 / 👎.

Co-authored-by: Codex <noreply@openai.com>

aibrahim-oai · 2026-03-24T03:21:27Z

@codex review this

chatgpt-codex-connector · 2026-03-24T03:37:02Z

Codex Review: Didn't find any major issues. Breezy!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

aibrahim-oai · 2026-03-24T05:45:03Z

@codex review this

chatgpt-codex-connector · 2026-03-24T05:55:32Z

Codex Review: Didn't find any major issues. Hooray!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Create codex-git-utils, move the existing git helpers into it, and migrate the GitInfo helpers out of core so rollout can depend on the shared crate without keeping its own git info module. Co-authored-by: Codex <noreply@openai.com>

Co-authored-by: Codex <noreply@openai.com>

Keep the git-utils extraction behavior-neutral by restoring the protocol-owned GitInfo type and reverting rename-only string drift.\n\nCo-authored-by: Codex <noreply@openai.com>

Revert the unrelated registry refresh from the git-utils extraction and keep only the minimal workspace lockfile changes needed for the moved crate.\n\nCo-authored-by: Codex <noreply@openai.com>

Remove the git-utils dev-dependency cycle by letting codex-core own the git-info tests again while the shared crate keeps the runtime implementation.\n\nCo-authored-by: Codex <noreply@openai.com>

Co-authored-by: Codex <noreply@openai.com>

bolinfest · 2026-03-24T17:26:55Z

codex-rs/git-utils/src/info.rs


+#[derive(Serialize, Deserialize, Clone, Debug, JsonSchema, TS)]
+pub struct GitInfo {
+    /// Current commit hash (SHA)


Comment clarify that this is the hex string representation.

Why don't we continue to use the newtype:

pub struct GitSha(pub String);

bolinfest · 2026-03-24T17:44:55Z

codex-rs/app-server-protocol/src/protocol/common.rs

-
-impl GitSha {
-    pub fn new(sha: &str) -> Self {
-        Self(sha.to_string())


It feels a little irresponsible to me that we don't verify sha is a hex string of 40 digits, but maybe there is a reason why we didn't...

bolinfest · 2026-03-24T17:48:58Z

codex-rs/git-utils/src/info.rs

+pub struct GitInfo {
+    /// Current commit hash (SHA)
+    #[serde(skip_serializing_if = "Option::is_none")]
+    pub commit_hash: Option<String>,


Can/should this be GitSha?

bolinfest · 2026-03-24T17:49:28Z

codex-rs/git-utils/src/info.rs

    }

-    let git_dir_path = canonicalize_or_raw(resolve_path(&repo_root, &PathBuf::from(git_dir_rel)));
+    let git_dir_path = canonicalize_or_raw({


Feels like a job for AbsolutePathBuf?

aibrahim-oai force-pushed the codex/extract-git-utils-crate branch from f9a12b9 to 56b3e16 Compare March 23, 2026 22:03

aibrahim-oai force-pushed the codex/extract-git-utils-crate branch from 56b3e16 to 12948a4 Compare March 23, 2026 23:34

aibrahim-oai added a commit that referenced this pull request Mar 23, 2026

codex: fix CI failure on PR #15564

8ab8b7a

Co-authored-by: Codex <noreply@openai.com>

aibrahim-oai added a commit that referenced this pull request Mar 24, 2026

codex: fix base PR compile failure (#15564)

fac2f92

Co-authored-by: Codex <noreply@openai.com>

aibrahim-oai added a commit that referenced this pull request Mar 24, 2026

codex: fix git-utils Bazel target on PR #15564

9ebd757

Co-authored-by: Codex <noreply@openai.com>

aibrahim-oai added a commit that referenced this pull request Mar 24, 2026

codex: fix chatwidget import lint on PR #15564

c4eb150

Co-authored-by: Codex <noreply@openai.com>

github-actions bot mentioned this pull request Mar 24, 2026

📊 AI CLI 工具社区动态日报 2026-03-24 gsscsd/big_model_radar#86

Open

aibrahim-oai added a commit that referenced this pull request Mar 24, 2026

codex: fix CI failure on PR #15564

2d20a5c

Co-authored-by: Codex <noreply@openai.com>

aibrahim-oai added a commit that referenced this pull request Mar 24, 2026

codex: fix CI failure on PR #15564

19954e8

Co-authored-by: Codex <noreply@openai.com>

aibrahim-oai added a commit that referenced this pull request Mar 24, 2026

codex: fix CI failure on PR #15564

05fdd24

Co-authored-by: Codex <noreply@openai.com>

chatgpt-codex-connector bot reviewed Mar 24, 2026

View reviewed changes

aibrahim-oai added a commit that referenced this pull request Mar 24, 2026

codex: remove tar advisory ignores from PR #15564

d8d8b44

Co-authored-by: Codex <noreply@openai.com>

aibrahim-oai added a commit that referenced this pull request Mar 24, 2026

codex: upgrade tar on PR #15564

c49a339

Co-authored-by: Codex <noreply@openai.com>

aibrahim-oai and others added 9 commits March 24, 2026 14:56

Move git utilities into a dedicated crate

88b0816

Create codex-git-utils, move the existing git helpers into it, and migrate the GitInfo helpers out of core so rollout can depend on the shared crate without keeping its own git info module. Co-authored-by: Codex <noreply@openai.com>

codex: fix CI failure on PR #15564

d572ce0

Co-authored-by: Codex <noreply@openai.com>

codex: fix base PR compile failure (#15564)

06eb7b2

Co-authored-by: Codex <noreply@openai.com>

codex: fix git-utils Bazel target on PR #15564

ca4668c

Co-authored-by: Codex <noreply@openai.com>

codex: fix chatwidget import lint on PR #15564

6498a42

Co-authored-by: Codex <noreply@openai.com>

Restore protocol-owned git info

bdcf87a

Keep the git-utils extraction behavior-neutral by restoring the protocol-owned GitInfo type and reverting rename-only string drift.\n\nCo-authored-by: Codex <noreply@openai.com>

Trim git utils lockfile churn

b04875f

Revert the unrelated registry refresh from the git-utils extraction and keep only the minimal workspace lockfile changes needed for the moved crate.\n\nCo-authored-by: Codex <noreply@openai.com>

Move git info tests back to core

a375b3f

Remove the git-utils dev-dependency cycle by letting codex-core own the git-info tests again while the shared crate keeps the runtime implementation.\n\nCo-authored-by: Codex <noreply@openai.com>

codex: fix CI failure on PR #15564

4540428

Co-authored-by: Codex <noreply@openai.com>

aibrahim-oai and others added 3 commits March 24, 2026 14:56

codex: fix CI failure on PR #15564

552fbf8

Co-authored-by: Codex <noreply@openai.com>

codex: remove tar advisory ignores from PR #15564

2c565c1

Co-authored-by: Codex <noreply@openai.com>

codex: upgrade tar on PR #15564

a18d733

Co-authored-by: Codex <noreply@openai.com>

aibrahim-oai force-pushed the codex/extract-git-utils-crate branch from c49a339 to a18d733 Compare March 24, 2026 14:57

bolinfest reviewed Mar 24, 2026

View reviewed changes

aibrahim-oai added 3 commits March 24, 2026 10:34

fix

cf1ccaa

fix

7eef491

lint

b3b9e07

bolinfest approved these changes Mar 24, 2026

View reviewed changes

aibrahim-oai added 3 commits March 24, 2026 11:13

fix

c2eee6e

Merge branch 'main' into codex/extract-git-utils-crate

2ee8d84

fix

8e88943

aibrahim-oai merged commit 0f957a9 into main Mar 24, 2026
36 of 39 checks passed

aibrahim-oai deleted the codex/extract-git-utils-crate branch March 24, 2026 20:26

github-actions bot locked and limited conversation to collaborators Mar 24, 2026

Conversation

aibrahim-oai commented Mar 23, 2026

Uh oh!

aibrahim-oai commented Mar 23, 2026

Uh oh!

chatgpt-codex-connector bot commented Mar 23, 2026

Uh oh!

aibrahim-oai commented Mar 24, 2026

Uh oh!

aibrahim-oai commented Mar 24, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

aibrahim-oai commented Mar 24, 2026

Uh oh!

chatgpt-codex-connector bot commented Mar 24, 2026

Uh oh!

aibrahim-oai commented Mar 24, 2026

Uh oh!

chatgpt-codex-connector bot commented Mar 24, 2026

Uh oh!

bolinfest Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

bolinfest Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

bolinfest Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

bolinfest Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants