Attach network approval reviews to parent tool items#15439
Attach network approval reviews to parent tool items#15439charley-oai wants to merge 5 commits intomainfrom
Conversation
Co-authored-by: Codex <noreply@openai.com>
|
@codex review |
|
Codex Review: Didn't find any major issues. 🎉 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7b565d13a2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Do not collapse legacy network approval review notifications onto the parent tool item id. Co-authored-by: Codex <noreply@openai.com>
|
Superseded by #15469, which keeps the parent item id typed without overloading targetItemId. |
Summary
GuardianApprovalRequest::NetworkAccesstargetItemIdfor attributednetwork_accessreviewsTesting
just fmtcargo test -p codex-core guardian_request_turn_id_prefers_network_access_owner_turnverification on a cold cache; stopped before completion while opening this PR