Skip to content

Attach network approval reviews to parent tool items#15439

Closed
charley-oai wants to merge 5 commits intomainfrom
cc/network-approval-parent-item-id
Closed

Attach network approval reviews to parent tool items#15439
charley-oai wants to merge 5 commits intomainfrom
cc/network-approval-parent-item-id

Conversation

@charley-oai
Copy link
Collaborator

Summary

  • carry an optional parent tool item id on GuardianApprovalRequest::NetworkAccess
  • use that parent id when app-server populates guardian review targetItemId for attributed network_access reviews
  • keep the existing fallback to the guardian review id when no parent tool item can be determined
  • add focused tests and update the app-server README

Testing

  • just fmt
  • started focused cargo test -p codex-core guardian_request_turn_id_prefers_network_access_owner_turn verification on a cold cache; stopped before completion while opening this PR

Co-authored-by: Codex <noreply@openai.com>
@charley-oai
Copy link
Collaborator Author

@codex review

@chatgpt-codex-connector
Copy link
Contributor

Codex Review: Didn't find any major issues. 🎉

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

charley-oai and others added 3 commits March 22, 2026 01:01
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
@charley-oai
Copy link
Collaborator Author

@codex review

Copy link
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7b565d13a2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Do not collapse legacy network approval review notifications onto the parent tool item id.

Co-authored-by: Codex <noreply@openai.com>
@charley-oai
Copy link
Collaborator Author

Superseded by #15469, which keeps the parent item id typed without overloading targetItemId.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant