Skip to content

fix(cli): show progress while patching findings - #950

Closed
cstolting-collab wants to merge 1 commit into
openai:mainfrom
cstolting-collab:cml/pr-931-patch-progress
Closed

cstolting-collab wants to merge 1 commit into
openai:mainfrom
cstolting-collab:cml/pr-931-patch-progress

Conversation

@cstolting-collab

Copy link
Copy Markdown

Summary

Rebases the implementation from #931 onto current main and resolves the test-file merge conflict.

The original feature is by @ianw-oai. This branch preserves the original README.md and src/cli.ts changes, and retains both current-main test additions and the new patch-progress regressions in tests-ts/cli-patch.test.ts.

Behavior

After findings are approved for patching, the CLI shows the current finding, elapsed time, and live activity. It retains completed results in terminal history, writes progress to stderr, uses plain progress for headless and redirected output, and stops the timer on completion, failure, or interruption.

Validation

  • The three named progress regressions failed on the current-main baseline and passed with this candidate.
  • bun test --timeout 30000 --seed 12345 tests-ts/cli-patch.test.ts tests-ts/cli-verify-fix.test.ts tests-ts/cli-skills.test.ts: 111 passed, 0 failed.
  • pnpm run types: passed.
  • pnpm run build:ci: passed.
  • pnpm exec prettier --check src/cli.ts tests-ts/cli-patch.test.ts README.md: passed.
  • Git whitespace and post-test tracked-file checks passed.

The full upstream suite and a live cloud-agent session were not run.

Attribution

This branch is a rebase and conflict resolution of #931. A local CML evaluation runner guarded repository, revision, scope, plan, and patch identity during verification; it did not generate the original feature or assess TypeScript semantics. No CML runtime code is included in this PR.

@github-actions github-actions Bot added the bug Something isn't working label Sep 17, 2026
@mldangelo-oai

Copy link
Copy Markdown
Collaborator

The original change has now merged in #931, including the refreshed tests and progress corrections. Closing this duplicate; thank you for refreshing and validating the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants