fix(cli): show progress while patching findings - #950
Closed
cstolting-collab wants to merge 1 commit into
Closed
cstolting-collab wants to merge 1 commit into
cstolting-collab wants to merge 1 commit into
Conversation
3 tasks
Collaborator
|
The original change has now merged in #931, including the refreshed tests and progress corrections. Closing this duplicate; thank you for refreshing and validating the change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rebases the implementation from #931 onto current
mainand resolves the test-file merge conflict.The original feature is by @ianw-oai. This branch preserves the original
README.mdandsrc/cli.tschanges, and retains both current-main test additions and the new patch-progress regressions intests-ts/cli-patch.test.ts.Behavior
After findings are approved for patching, the CLI shows the current finding, elapsed time, and live activity. It retains completed results in terminal history, writes progress to stderr, uses plain progress for headless and redirected output, and stops the timer on completion, failure, or interruption.
Validation
bun test --timeout 30000 --seed 12345 tests-ts/cli-patch.test.ts tests-ts/cli-verify-fix.test.ts tests-ts/cli-skills.test.ts: 111 passed, 0 failed.pnpm run types: passed.pnpm run build:ci: passed.pnpm exec prettier --check src/cli.ts tests-ts/cli-patch.test.ts README.md: passed.The full upstream suite and a live cloud-agent session were not run.
Attribution
This branch is a rebase and conflict resolution of #931. A local CML evaluation runner guarded repository, revision, scope, plan, and patch identity during verification; it did not generate the original feature or assess TypeScript semantics. No CML runtime code is included in this PR.