fix: seal drafts with empty artifact lists - #941
Merged
Merged
Conversation
ianw-oai
marked this pull request as ready for review
September 16, 2026 14:55
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
kmbroai
approved these changes
Sep 16, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A draft with
scan.artifacts: []was treated as a sealed scan. Finalization failed before it could create the report and SARIF export. Treat the empty list as absent when the draft has no seal timestamp.Fixes #930.
Changes
Testing
All passed:
PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 PYTHONDONTWRITEBYTECODE=1 python -m pytest plugins/codex-security/tests/test_finalize_scan_contract.py plugins/codex-security/tests/test_validate_scan_contract.py plugins/codex-security/tests/test_scan_contract_examples.py -q— 184 tests.python -m ruff check --config plugins/codex-security/pyproject.toml plugins/codex-security— Ruff 0.16.6, run throughuv.python -m ruff format --check --config plugins/codex-security/pyproject.toml plugins/codex-security— Ruff 0.16.6, run throughuv.pnpm --dir sdk/typescript run build:ci.node .github/scripts/check_plugin_source_compatibility.mjs.node --test .github/scripts/test_check_plugin_source_compatibility.mjs— 9 tests.git diff --cached --check.Risk and rollout
Low risk. The change applies only to drafts with no seal timestamp and an empty artifact list. Existing seal validation stays in place. No public CLI changes.
Public disclosure review