feat(cli): support custom patch validation prompts - #940
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
Security findingsBlocking findings (2)
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
🛡️ Codex Security Review · Automatically triggered
Here are some automated security review suggestions for this pull request.
Reviewed commit: d85399b116
ℹ️ About Codex security reviews in GitHub
This is an experimental Codex feature. Security reviews are triggered when:
- You comment "@codex security review"
- A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review
Once complete, Codex will leave suggestions, or a comment if no findings are found.
There was a problem hiding this comment.
🛡️ Codex Security Review · Automatically triggered
Here are some automated security review suggestions for this pull request.
Reviewed commit: f48b8b9eee
ℹ️ About Codex security reviews in GitHub
This is an experimental Codex feature. Security reviews are triggered when:
- You comment "@codex security review"
- A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review
Once complete, Codex will leave suggestions, or a comment if no findings are found.
Summary
patchcan now use environment-specific build, test, and runtime instructions to validate a generated fix through--validation-prompt-file PATH, matching the flag already available onscan.Changes
Testing
pnpm run types,pnpm run format, andgit diff --checkpassed. Directory-link regression tests failed before the fixes and passed afterward, including invocation from subdirectories and nested worktrees; explicitly selected file controls continue to pass.pnpm run build:ciandpnpm run build:pluginpassed. Localpnpm run test --seed 12345: 3,064 passed, 50 skipped, 11 failed. All 11 failures reproduce on unchangedmain: authentication fixtures encounter a pre-existing Git marker in the local temporary directory.Risk and rollout
The flag is optional and has no default prompt. Existing behavior, sandbox permissions, and output contracts remain unchanged when it is omitted. Validation runs inside the patch task using its existing permissions and result contract. Tests use deterministic Codex fixtures; no live model validation was run.
Public disclosure review