Skip to content

fix(reports): retain distinct source remediations - #905

Open
mldangelo-oai wants to merge 7 commits into
mainfrom
mdangelo/codex/retain-source-remediations
Open

mldangelo-oai wants to merge 7 commits into
mainfrom
mdangelo/codex/retain-source-remediations

Conversation

@mldangelo-oai

@mldangelo-oai mldangelo-oai commented Sep 12, 2026

Copy link
Copy Markdown
Collaborator

Summary

Standard completion and Deep reduction retain source findings whose fixes can disappear from the rendered report. Include distinct fixes, tests and preventive controls from saved previous findings and nested source provenance.

Changes

  • Traverse retained provenance in the existing standalone formatter for inline and linked reports.
  • Preserve source order, deduplicate identical text and keep saved findings and linked writeups intact.
  • Exercise actual Standard consolidation and nested Deep publication; separate fixture mutation from assertions.

Testing

  • Publication regression: parent 89ea5a87 has four expected failures and two passing controls; final 4d729e8a passes all six cases.
  • At runtime-identical 321e64e0, affected report, finalization, publication and recovery suites pass 305 cases with two filesystem-specific skips. The final commit changes only test fixture setup.
  • All five required portable checks pass at the final head, including nine source-compatibility tests.
  • Three fresh native reviews and an independent verifier report no actionable findings against main f5adb33a.
  • Original environment and setup failures remain recorded. The preceding head's CI passed after retrying a Docker Hub 502 before the container build; the final head’s CI passed, including Linux, macOS, Windows and installed-package checks.

Risk and rollout

This change displays remediation already retained in accepted findings. It is limited to report rendering and preserves existing schemas, commands and scan execution behavior. Linked writeup contents remain intact.

Public disclosure review

  • No customer, partner, prospect, or user identities, data, or identifying details are included.
  • No credentials, personal data, private source, scan findings, or nonpublic links or tickets are included.
  • I reviewed the branch name, title, description, commits, changes, comments, logs, screenshots, attachments, and links for public disclosure.

@github-actions github-actions Bot added the bug Something isn't working label Sep 12, 2026
@mldangelo-oai

Copy link
Copy Markdown
Collaborator Author

@codex review

Please review the current head, d013b71eb6a1ee7657fa597c1aa504c93e56107e.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 12, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-16T05:57:35.024407Z 4d729e8 Draft marked ready
🔒 Security Review Completed 2026-09-16T05:59:03.467431Z 4d729e8 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Hooray!

Reviewed commit: d013b71eb6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@mldangelo-oai

Copy link
Copy Markdown
Collaborator Author

@codex review

Please review current head 4b23ee3cbba79abc01d5171be2d01504c91fa674 against main at 7b77956c3067861559d31a3f3f791209b403643d. This update merges main and strengthens both inline and linked-report coverage for source-specific tests and preventive controls, including sources with identical remediation text. The focused report/publication suite and required portable checks pass; the regression cases fail against unchanged main.

@mldangelo-oai

Copy link
Copy Markdown
Collaborator Author

@codex security review

Please review current head 4b23ee3cbba79abc01d5171be2d01504c91fa674.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: 4b23ee3cbb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@mldangelo-oai mldangelo-oai changed the title fix: preserve distinct source remediations in reports fix(reports): retain distinct source remediations Sep 16, 2026
@mldangelo-oai

Copy link
Copy Markdown
Collaborator Author

@codex review

Please review current head 89ea5a87b75d2791daf112828c73adb8c2cc31c0 against main 1a3ca64333f894426dde0c0a7721d717c99f8cba. The refreshed regressions exercise real Standard/Deep publication and inline/linked reports, preserving distinct source fixes and source-specific tests without duplicate text.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 89ea5a87b7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread plugins/codex-security/scripts/report_projection.py Outdated
@mldangelo-oai

Copy link
Copy Markdown
Collaborator Author

@codex review

Please review current head 321e64e09a03790172b52f1fd4b435f35c9f1c9d against main 1a3ca64333f894426dde0c0a7721d717c99f8cba. This addresses the retained-provenance finding: the standalone renderer now traverses previousFindings and nested sourceFindings. Regressions exercise actual Standard consolidation and nested Deep publication in inline and linked reports, preserving distinct fixes, tests, controls and source bytes.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: 321e64e09a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@mldangelo-oai

Copy link
Copy Markdown
Collaborator Author

@codex review

Please review current head 4d729e8a9cc99d6962400c487b7c1bcb479ce087 against main f5adb33ab7d1f86b252d703a8af45d47de7f9486.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Another round soon, please!

Reviewed commit: 4d729e8a9c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@mldangelo-oai
mldangelo-oai marked this pull request as ready for review September 16, 2026 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant