Skip to content

fix(scan): make saved results match the final draft #883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ianw-oai wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix(scan): make saved results match the final draft #883

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c6bcadd
fix(scan): preserve candidate closure
ianw-oai Sep 11, 2026
51daf77
Merge main before simplifying scan completion
ianw-oai Sep 12, 2026
5e0a2d1
fix(scan): save the final submitted results
ianw-oai Sep 12, 2026
2e0b866
fix(scan): keep phase updates without file counts
ianw-oai Sep 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
741 changes: 61 additions & 680 deletions plugins/codex-security/mcp-app/src/artifact-scan-draft.ts
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions plugins/codex-security/mcp-app/src/scan-handoff.ts
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions plugins/codex-security/mcp-app/src/server/compact-artifact-tools.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ export function registerScanDraftTools(
registerCompactTool(server, {
name: "record_codex_security_scan_draft",
title: "Record Codex Security Scan Draft",
description: "Save semantic findings and coverage as an unsealed draft. Use complete:false for progress checkpoints, then complete:true for the final result; keep unvalidated candidates in coverage.deferred.",
description: "Save semantic findings and coverage as an unsealed draft. Each call replaces the current result. Use complete:false while working and complete:true for the final result. Earlier checkpoints are kept for interruption recovery.",
inputSchema: scanDraftInputSchema,
readOnly: false,
handler: async (value, requestContext) => {
Expand Down Expand Up @@ -297,7 +297,7 @@ export function registerCompactWorkerArtifactTools(
registerCompactTool(server, {
name: "record_codex_security_scan_draft",
title: "Record Codex Security Scan Draft",
description: "Save this Standard worker's semantic findings and coverage. Use complete:false for progress checkpoints, then complete:true for its final result; keep unvalidated candidates in coverage.deferred.",
description: "Save this Standard worker's findings and coverage. Each call replaces its current result. Use complete:false while working and complete:true for the final result. Earlier checkpoints are kept for interruption recovery.",
inputSchema: scanDraftInputSchema,
readOnly: false,
handler: async (value) => recordCodexSecurityWorkerScanDraft(
Expand Down
Loading
Loading