Preserve DOCX manual line breaks - #186
Open
dipeshbabu wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<w:br/>Root cause
The DOCX extractor handled paragraph endings and tabs before stripping XML tags, but it did not handle WordprocessingML break elements. The generic tag removal therefore deleted
<w:br/>without inserting whitespace and concatenated text from either side.Impact
Prepared DOCX knowledge bases retain word boundaries and line structure around manual breaks, improving the text supplied to scans.
Overlap check
Searched open issues and pull requests for DOCX line breaks, manual knowledge-base breaks, and
w:br; no overlapping work was found.Validation
pnpm dlx bun test --timeout 30000 ./tests-ts/knowledge-base.test.ts(5 passed, 2 platform skips)pnpm exec tsc --noEmitpnpm exec prettier --check src/knowledge-base.ts tests-ts/knowledge-base.test.tsgit diff --check