Allow scan options during bulk discovery - #175
Open
dipeshbabu wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--workers,--mode,--max-attempts,--plugin-path, and--pythonwhen starting interactive bulk-scan discovery--output-dir, which belongs to CSV-driven bulk scans because the discovery wizard selects its own destination--option=valueformsRoot cause
The command schema parsed all bulk-scan options correctly, and the scan runner consumed them after discovery. A second hand-written argv whitelist admitted only
--model,--effort, and--codex, so other valid options failed before the wizard started.Impact
Interactive discovery can now use the same concurrency, mode, retry, plugin, and Python settings as CSV-driven bulk scans. CSV behavior is unchanged.
Overlap check
Open issues and pull requests were reviewed, followed by repository-wide searches for interactive bulk-scan options, workers, retries, plugin paths, and Python configuration. No active issue or pull request overlaps this fix. Issue #45 concerns Docker option ordering with an explicit CSV, and PR #124 is documentation-only.
Validation
pnpm dlx bun test --timeout 30000 ./tests-ts/cli.test.ts— 85 passedpnpm exec tsc --noEmitpnpm exec prettier --check src/cli.ts tests-ts/cli.test.tsgit diff --check