Skip to content

test: stabilize ChatGPT login subprocess on macOS - #168

Open
mldangelo-oai wants to merge 1 commit into
mainfrom
mdangelo/codex/stabilize-chatgpt-login-test-20260730
Open

test: stabilize ChatGPT login subprocess on macOS#168
mldangelo-oai wants to merge 1 commit into
mainfrom
mdangelo/codex/stabilize-chatgpt-login-test-20260730

Conversation

@mldangelo-oai

@mldangelo-oai mldangelo-oai commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Flush the synthetic ChatGPT-login URL to stderr before explicitly terminating its child process.
  • Prevent the ambient-credential authentication regression test from leaving a dangling Bun/Node subprocess or stalling macOS CI.
  • Keep the change limited to the test fixture: no production authentication changes and no unrelated GitHub Actions upgrades.

Evidence

  • The merged-main macOS job timed out in CodexSecurity orchestration > keeps ambient credentials available after successful ChatGPT login: https://github.com/openai/codex-security/actions/runs/30593828967/attempts/1
  • Full SDK regression suite: 656 passed, 6 intentionally skipped, 0 failed, across 32 files.
  • The exact previously flaky test passed all 12 concurrent stress attempts.
  • The complete API authentication suite passed: 67 tests.
  • Authentication process-boundary tests, TypeScript typechecking, Prettier, and git diff validation pass.

This intentionally does not claim to fix the broader production child-cancellation issue tracked separately in #131.

@mldangelo-oai

Copy link
Copy Markdown
Collaborator Author

@codex review

@github-actions github-actions Bot added the skip-release-notes Omit internal changes from generated release notes label Jul 31, 2026
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep it up!

Reviewed commit: 08fda92e21

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

Security review completed. No security issues were found in this pull request.

Reviewed commit: 08fda92e21

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-release-notes Omit internal changes from generated release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants