Skip to content

fix: keep credential homes private under trusted ancestry - #158

Closed
batmnnn wants to merge 1 commit into
openai:mainfrom
batmnnn:fix/secure-credential-home-ancestry
Closed

fix: keep credential homes private under trusted ancestry#158
batmnnn wants to merge 1 commit into
openai:mainfrom
batmnnn:fix/secure-credential-home-ancestry

Conversation

@batmnnn

@batmnnn batmnnn commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Summary

Test plan

  • bun test --timeout 60000 ./tests-ts/runtime.test.ts ./tests-ts/cli-authentication.test.ts
  • Posix: reject credential home under non-sticky shared parent
  • Posix: accept sticky shared parent owned by self/root
  • Posix: reject sticky parent owned by another UID
  • Posix: reject leaf that is no longer private after prepare
  • Posix: reject replaced credential home (different inode) on lock release
  • Posix: reject world-writable or symlink auth.json
  • CLI login/status/logout still share one canonical credential home

Made with Cursor

Reject non-sticky or untrusted parents for durable auth state, re-check
on every credential-home use path, harden auth.json, and pin identity
for the lock session so shared-volume rename races cannot steal auth.

Co-authored-by: Cursor <cursoragent@cursor.com>
Copilot AI review requested due to automatic review settings July 30, 2026 18:18

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@mldangelo-oai

Copy link
Copy Markdown
Collaborator

Thank you for working on credential-directory privacy. The protection and a more complete version of the related tests have already landed on main, so merging this older branch would duplicate the fix. I'm going to close it, and we'd welcome another security-focused contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Credential home under a shared parent can be renamed aside before auth use

3 participants