fix: keep credential homes private under trusted ancestry - #158
Closed
batmnnn wants to merge 1 commit into
Closed
Conversation
Reject non-sticky or untrusted parents for durable auth state, re-check on every credential-home use path, harden auth.json, and pin identity for the lock session so shared-volume rename races cannot steal auth. Co-authored-by: Cursor <cursoragent@cursor.com>
Collaborator
|
Thank you for working on credential-directory privacy. The protection and a more complete version of the related tests have already landed on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
auth.jsoninstead of scan output).auth.json: regular non-symlink file with private POSIX mode/owner before treating stored credentials as present.(st_dev, st_ino)for the duration of a credential-home lock session. Durable cross-process pins are deferred (no workbench row for credential homes); every-use re-validation covers the cross-user class.requireSecureOutputAncestry/requireTrustedOutputAncestorhelpers (compatible with fix: keep scan output private through completion and exports #118) used for credential-home trust; does not change scan-output prepare paths (left to fix: keep scan output private through completion and exports #118).Test plan
bun test --timeout 60000 ./tests-ts/runtime.test.ts ./tests-ts/cli-authentication.test.tsauth.jsonMade with Cursor