fix: ignore recommended plugin context in thread titles - #734
Open
fscfede-beep wants to merge 1 commit into
Open
fix: ignore recommended plugin context in thread titles#734fscfede-beep wants to merge 1 commit into
fscfede-beep wants to merge 1 commit into
Conversation
sylvesterkaczmarek
left a comment
sylvesterkaczmarek
left a comment
There was a problem hiding this comment.
Keeping the sanitisation title-only is the correct boundary: the task prompt still reaches Codex verbatim, so execution context is unchanged. Anchoring at the beginning prevents removing user text later in the prompt, and the non-greedy close-tag match limits stripping to the injected recommended_plugins block. The regression exercises the real task/thread path rather than only the helper. No blocker.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #726.
Codex Companion task threads are explicitly named from the task prompt. When Claude prepends its injected
<recommended_plugins>...</recommended_plugins>context block, that metadata currently becomes the visible Codex history title.This patch strips only a leading
recommended_pluginsblock before deriving the thread-name excerpt. The task prompt itself is unchanged and still reaches Codex verbatim; only the display-name source is sanitized.Validation
Windows 11 / Node 26.3.1:
--prompt-file: RED onupstream/mainwith thread nameCodex Companion Task: <recommended_plugins> Here is a list of plugins. </re...Codex Companion Task: Fix the flaky login testnode --check plugins/codex/scripts/lib/codex.mjsgit diff --checkFresh collision check immediately before publication found no open PR for #726.