365 - schedule validation - #383
Open
Lathrisk wants to merge 34 commits into
Open
Conversation
Lathrisk
added
the
schedule-related
Lathrisk
force-pushed
the
365/schedule-validation
branch
from
March 18, 2021 16:04
b6f8b70 to
ed6cd2d
Compare
Contributor
Lathrisk
force-pushed
the
365/schedule-validation
branch
2 times, most recently
from
March 24, 2021 16:50
1d31b77 to
8d48385
Compare
Lathrisk
marked this pull request as draft
March 24, 2021 16:51
Lathrisk
force-pushed
the
365/schedule-validation
branch
4 times, most recently
from
March 26, 2021 14:28
c5418ff to
6613cdd
Compare
nickevansuk
requested changes
Mar 30, 2021
nickevansuk
left a comment
nickevansuk
left a comment
Contributor
There was a problem hiding this comment.
A few comments on the work so far - great progress!
Lathrisk
force-pushed
the
365/schedule-validation
branch
2 times, most recently
from
March 31, 2021 10:57
9939ac5 to
1d8088e
Compare
Lathrisk
marked this pull request as ready for review
April 1, 2021 09:56
Lathrisk
marked this pull request as draft
April 1, 2021 15:39
added 10 commits
April 1, 2021 16:39
scheduleTimezone rule: update message with link to IANA
added 13 commits
April 1, 2021 16:40
…tion dates are outside the recurrence rule
…le (and data type rule)
Lathrisk
force-pushed
the
365/schedule-validation
branch
from
April 1, 2021 15:40
7525bda to
95c782f
Compare
added 6 commits
April 5, 2021 16:58
Set process.env.TZ before doing any timezone calculations
Lathrisk
marked this pull request as ready for review
April 8, 2021 16:05
Remove the process.env.TZ check - we explicitly set this Add a comment about setting this value
Lathrisk
force-pushed
the
365/schedule-validation
branch
from
April 8, 2021 16:15
1a14594 to
dc3ee61
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#365
This PR covers the issues listed in the ticket above.