Conversation
benderl
commented
Apr 7, 2026
- check for active user management before modifying roles
- restore: remove duplicate checks and inet dependency
There was a problem hiding this comment.
Pull request overview
This PR adjusts restore behavior and tightens Mosquitto DynSec ACL-role handling so roles are only modified when user management is active.
Changes:
- Restore flow: remove the internet dependency in
atreboot.shand alignrestore.shstep numbering withprepare_restore.sh. - ACL roles: gate
add_acl_role/remove_acl_rolecalls behind theuser_management_activeflag for vehicles, chargepoints, IO devices/actions, and components.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 12 comments.
| File | Description |
|---|---|
runs/restore.sh |
Removes duplicated validation steps (now handled in prepare_restore.sh) and renumbers log steps. |
runs/atreboot.sh |
Always triggers restore.sh when a pending restore flag exists (no longer dependent on internet detection). |
packages/helpermodules/subdata.py |
Only adds/removes vehicle write-access role when user management is active. |
packages/helpermodules/command.py |
Adds user-management-active checks before creating/removing multiple ACL roles for newly created/removed entities. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.