Skip to content

Fixes#3269

Merged
benderl merged 4 commits intoopenWB:masterfrom
benderl:fixes
Apr 9, 2026
Merged

Fixes#3269
benderl merged 4 commits intoopenWB:masterfrom
benderl:fixes

Conversation

@benderl
Copy link
Copy Markdown
Contributor

@benderl benderl commented Apr 7, 2026

  • check for active user management before modifying roles
  • restore: remove duplicate checks and inet dependency

@benderl benderl added the bug Something isn't working label Apr 7, 2026
@benderl benderl requested a review from LKuemmel April 7, 2026 11:27
@LKuemmel LKuemmel requested a review from Copilot April 7, 2026 12:58
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts restore behavior and tightens Mosquitto DynSec ACL-role handling so roles are only modified when user management is active.

Changes:

  • Restore flow: remove the internet dependency in atreboot.sh and align restore.sh step numbering with prepare_restore.sh.
  • ACL roles: gate add_acl_role/remove_acl_role calls behind the user_management_active flag for vehicles, chargepoints, IO devices/actions, and components.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 12 comments.

File Description
runs/restore.sh Removes duplicated validation steps (now handled in prepare_restore.sh) and renumbers log steps.
runs/atreboot.sh Always triggers restore.sh when a pending restore flag exists (no longer dependent on internet detection).
packages/helpermodules/subdata.py Only adds/removes vehicle write-access role when user management is active.
packages/helpermodules/command.py Adds user-management-active checks before creating/removing multiple ACL roles for newly created/removed entities.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread runs/restore.sh Outdated
Comment thread packages/helpermodules/command.py
Comment thread packages/helpermodules/command.py
Comment thread packages/helpermodules/command.py
Comment thread packages/helpermodules/command.py Outdated
Comment thread packages/helpermodules/command.py
Comment thread packages/helpermodules/command.py
Comment thread packages/helpermodules/command.py
Comment thread packages/helpermodules/command.py Outdated
Comment thread packages/helpermodules/command.py
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/helpermodules/subdata.py Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread runs/restore.sh
Comment thread runs/restore.sh
@benderl benderl merged commit a7e6fd7 into openWB:master Apr 9, 2026
5 checks passed
@benderl benderl deleted the fixes branch April 9, 2026 11:07
LKuemmel pushed a commit that referenced this pull request Apr 10, 2026
* check for active user management before modifying acl roles

* restore: remove duplicate checks and inet dependency

* fix charge point get_values in secure mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants