Skip to content

Conversation

@ehennestad
Copy link
Collaborator

@ehennestad ehennestad commented Oct 30, 2024

Issue #23

@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2024

Test Results

464 tests  ±0   464 ✅ ±0   1m 1s ⏱️ +5s
  6 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit d9c89a9. ± Comparison against base commit c963f18.

♻️ This comment has been updated with latest results.

@ehennestad ehennestad changed the title Add codemeta.json (Issue#23) Add codemeta.json (Issue #23) Oct 30, 2024
@ehennestad ehennestad changed the title Add codemeta.json (Issue #23) Add codemeta.json Oct 30, 2024
@codecov
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.39%. Comparing base (c963f18) to head (d9c89a9).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #30   +/-   ##
=======================================
  Coverage   36.39%   36.39%           
=======================================
  Files         326      326           
  Lines        3171     3171           
=======================================
  Hits         1154     1154           
  Misses       2017     2017           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ehennestad ehennestad requested a review from lzehl October 30, 2024 20:57
Copy link
Member

@lzehl lzehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey. I had a look (see my smaller comments) but I would suggest to pull in @apdavison as reviewer.

"description": "openMINDS MATLAB is a toolbox to support the creation and use of openMINDS metadata models and schemas in MATLAB, with import and export in JSON-LD format. The package contains all openMINDS schemas as MATLAB classes in addition to schema base classes and utility methods.",
"applicationCategory": "neuroscience",
"releaseNotes": "https://github.com/openMetadataInitiative/openMINDS_MATLAB/releases",
"funding": "https://cordis.europa.eu/project/id/945539",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that this is not enough (depending on the version). Right now you would receive funding through EBRAINS 2.0 I guess?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this not be an array? with funder inside? not sure how codemeta handles this...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as as I can see from the schema, it does not support lists for funder

@ehennestad ehennestad requested a review from apdavison March 28, 2025 15:33
Copy link
Member

@apdavison apdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me. This is what the software card looks like, based on the codemeta.json: https://search.kg.ebrains.eu/live/cc77433c-29ea-44cd-8cae-e7fcf18e774b

@ehennestad ehennestad merged commit 0856c5d into main Apr 3, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants