-
Notifications
You must be signed in to change notification settings - Fork 3
Add codemeta.json #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #30 +/- ##
=======================================
Coverage 36.39% 36.39%
=======================================
Files 326 326
Lines 3171 3171
=======================================
Hits 1154 1154
Misses 2017 2017 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lzehl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey. I had a look (see my smaller comments) but I would suggest to pull in @apdavison as reviewer.
| "description": "openMINDS MATLAB is a toolbox to support the creation and use of openMINDS metadata models and schemas in MATLAB, with import and export in JSON-LD format. The package contains all openMINDS schemas as MATLAB classes in addition to schema base classes and utility methods.", | ||
| "applicationCategory": "neuroscience", | ||
| "releaseNotes": "https://github.com/openMetadataInitiative/openMINDS_MATLAB/releases", | ||
| "funding": "https://cordis.europa.eu/project/id/945539", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume that this is not enough (depending on the version). Right now you would receive funding through EBRAINS 2.0 I guess?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this not be an array? with funder inside? not sure how codemeta handles this...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as as I can see from the schema, it does not support lists for funder
apdavison
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok to me. This is what the software card looks like, based on the codemeta.json: https://search.kg.ebrains.eu/live/cc77433c-29ea-44cd-8cae-e7fcf18e774b
Issue #23