MQTT module aligning with external module layout#11
Merged
viacheslauK merged 24 commits intomainfrom Mar 9, 2026
Merged
Conversation
NikolaiShipilov
requested changes
Mar 3, 2026
NikolaiShipilov
left a comment
NikolaiShipilov
left a comment
There was a problem hiding this comment.
The changes lgtm.
However, it would be good to have the validation of these changes within the CI i.e. have additional jobs to build module against installed openDAQ SDK and run tests* (* at least on ubuntu runner) as we have it in other module repos e.g. here https://github.com/openDAQ/OpcUaModules/blob/main/.github/workflows/ci.yml .
It might be also useful to have various CI jobs with SSL enabled / disabled for paho lib.
viacheslauK
force-pushed
the
module-layout
branch
8 times, most recently
from
4e66ecb to
dea192b
Compare
viacheslauK
force-pushed
the
module-layout
branch
from
dea192b to
51c61ce
Compare
NikolaiShipilov
requested changes
Mar 9, 2026
modules/mqtt_streaming_module/include/mqtt_streaming_module/status_helper.h
Outdated
Show resolved
Hide resolved
modules/mqtt_streaming_module/src/mqtt_streaming_module_impl.cpp
Outdated
Show resolved
Hide resolved
shared/mqtt_streaming_protocol/tests/test_mqtt_streaming_protocol.cpp
Outdated
Show resolved
Hide resolved
Co-authored-by: NikolaiShipilov <127689162+NikolaiShipilov@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief: