[Fix #1737] Calculate communication status error code from cause. - #1739
Merged
Merged
Conversation
gmunozfe
reviewed
Oct 5, 2026
fjtirado
commented
Oct 5, 2026
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The timeout check misses the HTTP timeout exception types produced by JAX-RS connectors.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Updates HTTP transport error mapping to derive communication status codes from exception causes.
Changes:
- Changes the default communication status from 502 to 500.
- Maps recognized timeout causes to status 408.
| File | Description |
|---|---|
types/src/main/java/io/serverlessworkflow/types/Errors.java |
Updates the communication error default. |
impl/http/src/main/java/io/serverlessworkflow/impl/executors/http/AbstractRequestExecutor.java |
Derives transport status from the failure cause. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
… error code from cause. Fix open-workflow-specification#1737 Signed-off-by: Francisco Javier Tirado Sarti <ftirados@ibm.com>
fjtirado
commented
Oct 5, 2026
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The updated mapping addresses both timeout and non-timeout transport scenarios from issue #1737.
Review effort: Balanced
Findings: None
Resolved since last review (2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1737