feat(config): wire tracer/meter/logger configurator experimental fields by ocelotl · Pull Request #5418 · open-telemetry/opentelemetry-python

ocelotl · 2026-07-16T02:45:19Z

Description

The declarative configuration parser reads the experimental
tracer_configurator/development, meter_configurator/development and
logger_configurator/development fields into dataclass instances, but
create_tracer_provider, create_meter_provider and create_logger_provider
ignored them — the parsed values were silently discarded.

This wires each ExperimentalXConfigurator into the SDK's existing rule-based
configurator support:

Every per-scope entry (tracers / meters / loggers) becomes an
instrumentation-scope name-glob rule (via the SDK's
_scope_name_matches_glob) carrying that scope's enabled flag.
default_config supplies the fallback config for scopes matching no glob.
Rules are evaluated in order, so earlier entries take precedence.
The resulting configurator is passed to the provider constructor through its
_x_configurator keyword, so per-instrumentation-scope enabled overrides
now take effect (e.g. disabling a noisy tracer by name glob).

The logger minimum_severity and trace_based fields are accepted by the
config schema but have no equivalent in the Python SDK _LoggerConfig (which
only exposes is_enabled); when set they are ignored with a warning, matching
the existing pattern for unsupported log record limits.

Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Added TestTracerConfigurator, TestMeterConfigurator and
TestLoggerConfigurator covering: glob-match disabling, default_config
fallback for unmatched scopes, first-matching-rule-wins ordering, absent
enabled defaulting to enabled, no-configurator passthrough, and (logger) the
unsupported-fields warning. Each asserts behavior through the SDK provider's
_apply_*_configurator.

ruff check opentelemetry-configuration/ — clean
pytest opentelemetry-configuration/tests/ — 379 passed (16 new)

Does This PR Require a Contrib Repo Change?

No.

Checklist:

Followed the style guidelines of this project
Changelog updated (.changelog/5390.added)
Unit tests have been added
Documentation has been updated

github-actions · 2026-07-30T04:16:04Z

This PR has been automatically marked as stale because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 days of this comment.
If you're still working on this, please add a comment or push new commits.

opentelemetry-pr-dashboard · 2026-08-14T16:52:40Z

Pull request dashboard status

Waiting on the author · refreshed 2026-08-25 12:31 UTC

Respond to 2 review items (e.g. link a commit, explain why not, ask a follow-up):

Inline threads: 1
Top-level threads: 2

Status above doesn't look right?

Just replied or pushed? Anything around or after the refresh time above may not be picked up yet — give it a few minutes.
Should this be with reviewers? Comment /dashboard route:reviewers to route it to them.
Anything wrong — including the routing? Report it with what you expected; it helps us improve the dashboard.

xrmx

Could you please also add a test that verifies that we get what we expect from these configurator nodes in the yaml?

The declarative configuration parser reads the experimental tracer_configurator/development, meter_configurator/development and logger_configurator/development fields into dataclasses, but create_tracer_provider, create_meter_provider and create_logger_provider ignored them, so the parsed values were silently discarded. Map each ExperimentalXConfigurator to a rule-based SDK configurator: every per-scope entry becomes an instrumentation-scope name-glob rule carrying the scope's enabled flag, and default_config supplies the fallback config. The resulting configurator is passed to the provider constructor via the _x_configurator keyword, so per-instrumentation-scope enabled overrides now take effect. The logger minimum_severity and trace_based fields are accepted by the schema but unsupported by the Python SDK _LoggerConfig; they are ignored with a warning.

…ines

Load a YAML fixture exercising the tracer/meter/logger configurator/development nodes through load_config_file, then assert both that the parsed model tree matches expectations and that each provider created from it applies the per-scope enabled overrides.

Split the unsupported-field warning test so both minimum_severity and trace_based are covered by their own assertions.

The configurator files were formatted at a shorter line length; ruff format at the repo line-length collapses the wrapped lines. Reformat so the precommit CI job passes.

Copilot

Pull request overview

This PR updates the opentelemetry-configuration package so the experimental declarative-config fields for per-instrumentation-scope configurators (tracer_configurator/development, meter_configurator/development, logger_configurator/development) are no longer parsed-and-discarded, but instead are converted into the SDK’s existing rule-based configurator mechanism and passed into the corresponding SDK providers.

Changes:

Wire tracer/meter/logger experimental configurator config into create_tracer_provider, create_meter_provider, and create_logger_provider via SDK rule-based configurators and _scope_name_matches_glob.
Add unit tests for tracer/meter/logger configurator wiring behavior, plus an end-to-end YAML parse + wiring test.
Add a changelog entry documenting the new behavior and the logger unsupported-fields warning behavior.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
opentelemetry-configuration/src/opentelemetry/configuration/_tracer_provider.py	Build and pass a `_RuleBasedTracerConfigurator` derived from experimental config into `TracerProvider`.
opentelemetry-configuration/src/opentelemetry/configuration/_meter_provider.py	Build and pass a `_RuleBasedMeterConfigurator` derived from experimental config into `MeterProvider`.
opentelemetry-configuration/src/opentelemetry/configuration/_logger_provider.py	Build and pass a `_RuleBasedLoggerConfigurator` derived from experimental config into `LoggerProvider`, and warn when unsupported logger fields are provided.
opentelemetry-configuration/tests/test_tracer_provider.py	Add unit tests asserting tracer configurator rules are applied via `_apply_tracer_configurator`.
opentelemetry-configuration/tests/test_meter_provider.py	Add unit tests asserting meter configurator rules are applied via `_apply_meter_configurator`.
opentelemetry-configuration/tests/test_logger_provider.py	Add unit tests asserting logger configurator rules are applied and unsupported-fields warnings are emitted.
opentelemetry-configuration/tests/file/test_configurator_yaml.py	Add YAML-driven integration test validating parsing + provider wiring for all three configurators.
opentelemetry-configuration/tests/file/data/configurator_config.yaml	Add YAML fixture containing the configurator nodes used by the integration test.
.changelog/5418.added	Document the new configurator wiring and unsupported logger fields behavior.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

xrmx · 2026-08-25T12:27:30Z

+    if config.minimum_severity is not None or config.trace_based is not None:
+        _logger.warning(
+            "logger_configurator minimum_severity/trace_based are specified in "
+            "config but are not supported by the Python SDK LoggerProvider; "
+            "they will be ignored."
+        )


I think we can ignore this if we don't want to complicate things. Or merge the change if you are willing to update tests

github-actions Bot added the Stale label Jul 30, 2026

ocelotl force-pushed the issue_5390_wire_configurator_fields branch 2 times, most recently from 3f08c98 to 7cd19f2 Compare July 30, 2026 21:35

ocelotl marked this pull request as ready for review July 30, 2026 21:38

ocelotl requested a review from a team as a code owner July 30, 2026 21:38

otelbot-python Bot added this to Python PR digest Jul 30, 2026

github-actions Bot removed the Stale label Jul 31, 2026

ocelotl force-pushed the issue_5390_wire_configurator_fields branch from 5495695 to 59659ba Compare August 4, 2026 21:43

opentelemetry-pr-dashboard Bot mentioned this pull request Aug 14, 2026

Pull Request Dashboard #5550

Open

xrmx requested changes Aug 20, 2026

View reviewed changes

Comment thread opentelemetry-configuration/tests/test_logger_provider.py Outdated

github-project-automation Bot moved this to Reviewed PRs that need fixes in Python PR digest Aug 20, 2026

xrmx moved this from Reviewed PRs that need fixes to Ready for review in Python PR digest Aug 20, 2026

ocelotl force-pushed the issue_5390_wire_configurator_fields branch from 59659ba to 82bc843 Compare August 20, 2026 11:46

lzchen reviewed Aug 21, 2026

View reviewed changes

Comment thread opentelemetry-configuration/src/opentelemetry/configuration/_logger_provider.py

ocelotl and others added 6 commits August 24, 2026 08:45

Fix CI: rename changelog fragment to PR number and silence too-many-l…

8bbe04b

…ines

Re-trigger CI (flaky Windows getting-started test)

0829283

test(config): warn test for unsupported logger trace_based field

802e9e3

Split the unsupported-field warning test so both minimum_severity and trace_based are covered by their own assertions.

style(config): reformat to repo line-length 120

c814858

The configurator files were formatted at a shorter line length; ruff format at the repo line-length collapses the wrapped lines. Reformat so the precommit CI job passes.

ocelotl force-pushed the issue_5390_wire_configurator_fields branch from 3eca3d8 to c814858 Compare August 24, 2026 13:45

This was referenced Aug 24, 2026

Instrumentation scope glob matching is case-insensitive on Windows #5583

Open

fix(sdk): make instrumentation scope glob matching case-sensitive #5584

Open

xrmx approved these changes Aug 25, 2026

View reviewed changes

github-project-automation Bot moved this from Ready for review to Approved PRs in Python PR digest Aug 25, 2026

xrmx requested a lite review from Copilot August 25, 2026 10:26

Copilot started reviewing on behalf of xrmx August 25, 2026 10:26 View session

Copilot AI reviewed Aug 25, 2026

View reviewed changes

Navigation Menu

Uh oh!

feat(config): wire tracer/meter/logger configurator experimental fields - #5418

feat(config): wire tracer/meter/logger configurator experimental fields#5418
ocelotl wants to merge 6 commits into
open-telemetry:mainfrom
ocelotl:issue_5390_wire_configurator_fields

ocelotl commented Jul 16, 2026

Uh oh!

github-actions Bot commented Jul 30, 2026

Uh oh!

opentelemetry-pr-dashboard Bot commented Aug 14, 2026 •

edited

Loading

Uh oh!

xrmx left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

xrmx Aug 25, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

ocelotl commented Jul 16, 2026

Description

Type of change

How Has This Been Tested?

Does This PR Require a Contrib Repo Change?

Checklist:

Uh oh!

github-actions Bot commented Jul 30, 2026

Uh oh!

opentelemetry-pr-dashboard Bot commented Aug 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull request dashboard status

Uh oh!

xrmx left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

xrmx Aug 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

opentelemetry-pr-dashboard Bot commented Aug 14, 2026 •

edited

Loading

xrmx Aug 25, 2026 •

edited

Loading