Skip to content

Apply fixes for UP ruff rule#5133

Open
emdneto wants to merge 10 commits intoopen-telemetry:mainfrom
emdneto:up-ruff-rule
Open

Apply fixes for UP ruff rule#5133
emdneto wants to merge 10 commits intoopen-telemetry:mainfrom
emdneto:up-ruff-rule

Conversation

@emdneto
Copy link
Copy Markdown
Member

@emdneto emdneto commented Apr 21, 2026

Description


opentelemetry._logs._internal.LogRecord:1:more than one target located for cross-referencing 'Context': opentelemetry.context.Context, opentelemetry.context.context.Context

90% of the changes were made by ruff with ruff check --fix. The agent removed the unused imports and fixed minor issues.

Fixes #4227

Assisted-by: Copilot

Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
@emdneto emdneto requested a review from a team as a code owner April 21, 2026 22:42
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
@DylanRussell
Copy link
Copy Markdown
Contributor

nice. couple failed CI checks but otherwise LGTM

@github-project-automation github-project-automation Bot moved this to Approved PRs in Python PR digest Apr 22, 2026
@emdneto emdneto moved this from Approved PRs to Ready for review in Python PR digest Apr 22, 2026
emdneto added 2 commits April 22, 2026 09:13
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
Copy link
Copy Markdown
Member Author

@emdneto emdneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for manual changes i've done in 6051e44 and 874317d to make CI pass

@emdneto emdneto added the Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary label Apr 22, 2026
Copy link
Copy Markdown
Member

@MikeGoldsmith MikeGoldsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Some linter checks failed that will need to be cleaned up.

Comment thread CHANGELOG.md Outdated
emdneto added 4 commits April 25, 2026 15:23
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
@MikeGoldsmith MikeGoldsmith moved this from Ready for review to Approved PRs in Python PR digest Apr 27, 2026
emdneto added 2 commits April 27, 2026 09:08
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
@DylanRussell
Copy link
Copy Markdown
Contributor

If you have time I think we could do the same thing in the contrib repo: https://github.com/open-telemetry/opentelemetry-python-contrib/blob/main/pyproject.toml#L162

@emdneto
Copy link
Copy Markdown
Member Author

emdneto commented Apr 27, 2026

If you have time I think we could do the same thing in the contrib repo: https://github.com/open-telemetry/opentelemetry-python-contrib/blob/main/pyproject.toml#L162

That's the plan after getting this merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary

Projects

Status: Approved PRs

Development

Successfully merging this pull request may close these issues.

Add more rules to ruff linter

3 participants