Add missing return type annotations to LogRecordProcessor and LoggerProvider#5008
Open
joshwilhelmi wants to merge 1 commit intoopen-telemetry:mainfrom
Open
Add missing return type annotations to LogRecordProcessor and LoggerProvider#5008joshwilhelmi wants to merge 1 commit intoopen-telemetry:mainfrom
joshwilhelmi wants to merge 1 commit intoopen-telemetry:mainfrom
Conversation
…rovider The abstract `LogRecordProcessor.on_emit()` and `shutdown()` methods, `ConcurrentMultiLogRecordProcessor.on_emit()` and `shutdown()`, and `LoggerProvider.shutdown()` were missing `-> None` return type annotations. This causes mypy `no-untyped-call` errors for callers using strict type checking. The sibling classes (`MultiLogRecordProcessor`, `TracerProvider`) already have correct annotations — this aligns the logs module to match.
|
|
lzchen
approved these changes
Mar 24, 2026
Contributor
|
@joshwilhelmi I think that is one of the reasons we are using pyright :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Several methods in the
_logsmodule are missing-> Nonereturn type annotations, causing mypyno-untyped-callerrors for downstream callers using strict type checking:LogRecordProcessor.on_emit()(abstract)LogRecordProcessor.shutdown()(abstract)ConcurrentMultiLogRecordProcessor.on_emit()ConcurrentMultiLogRecordProcessor.shutdown()LoggerProvider.shutdown()The sibling classes (
MultiLogRecordProcessor.on_emit(),MultiLogRecordProcessor.shutdown(),TracerProvider.shutdown()) already have correct-> Noneannotations — this PR aligns the logs module to match.Changes
-> Nonereturn type annotation to the 5 methods listed aboveType of Change
Testing
No behavioral change — only adds missing type annotations. Existing tests are unaffected.