opentelemetry-sdk: cache tracer configs in Tracer#5007
Open
xrmx wants to merge 6 commits intoopen-telemetry:mainfrom
Open
opentelemetry-sdk: cache tracer configs in Tracer#5007xrmx wants to merge 6 commits intoopen-telemetry:mainfrom
xrmx wants to merge 6 commits intoopen-telemetry:mainfrom
Conversation
Instead of creating the TracerConfig at each start_span call, just compute it on change.
10 tasks
Contributor
Author
|
Benchmarks after |
herin049
reviewed
Mar 24, 2026
116b776 to
2dbca74
Compare
xrmx
commented
Mar 25, 2026
pmcollins
reviewed
Mar 25, 2026
Member
pmcollins
left a comment
There was a problem hiding this comment.
Looks like a positive change overall, thanks for doing this.
| ) | ||
|
|
||
| with self._tracers_lock: | ||
| self._tracers[instrumentation_scope] = tracer |
Member
There was a problem hiding this comment.
If there's already a Tracer with this instrumentation scope registered in _tracers, should it be returned? Looks like we're always creating a new Tracer, and if we overwrite a Tracer that's already registered in _tracers, it gets overwritten, then it won't be iterated over in _set_tracer_configurator, and won't receive config updates, even though it could still be in use.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Instead of creating the TracerConfig at each start_span call, just compute it on change. This changes an internal interface.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Contrib Repo Change?
Checklist: