Skip to content

introduce alls-green action for required checks - #4988

Merged
xrmx merged 21 commits into
open-telemetry:mainfrom
emdneto:required-checks
Apr 3, 2026
Merged

xrmx merged 21 commits into
open-telemetry:mainfrom
emdneto:required-checks

Conversation

@emdneto

@emdneto emdneto commented Mar 16, 2026 •

Copy link
Copy Markdown
Member

Context

All required CI checks are currently managed through Terraform in the admin repo, which makes it difficult to meet our tox -e generate-workflows approach. In some cases, it's hard to coordinate the Terraform update on the admin repo + updating our CI here.

We discussed internally on Slack about alls-green to remove that maintenance overhead and avoid requiring admin-repo Terraform updates whenever the required checks change.

I did some tests, when a job is skipped, the alls-green check respects that and skips the job as well during the check.

Important things to consider:

  • Reusable workflows add a small delay — expect around ~10 seconds before all jobs start being triggered by CI.
  • The alls-green check job only runs after every job listed under needs has finished.
  • The allowed-skips and allowed-failures options in alls-green work with the job names as defined in the ci.yml, not the nested job names. So you'd use allowed-skips: "misc,lint" rather than something like allowed-skips: "misc / public-symbols-check".

Changes

  • Implements alls-green action
  • Remove the complexity of having multiple test,misc and lint (eg., test_0.yml) files. Github Actions limitation is just for matrix.

Before merge

  • Make the job CI / check as required in Github -- this is the only one needed.
  • Update README.md with the correct link to the tests badge
  • Update admin repo to remove the old required checks
  • Update contrib repo to implement the same approach

emdneto added 2 commits March 16, 2026 20:48
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
@emdneto emdneto added the Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary label Mar 16, 2026
emdneto added 2 commits March 16, 2026 21:01
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
@emdneto emdneto removed Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary labels Mar 17, 2026
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
@emdneto emdneto added the Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary label Mar 17, 2026
@emdneto emdneto changed the title try alls-green for required checks introduce alls-green for required checks Mar 17, 2026
emdneto added 4 commits March 17, 2026 21:02
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
@emdneto emdneto removed the Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary label Mar 18, 2026
emdneto added 3 commits March 17, 2026 21:18
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
Comment thread tox.ini Outdated
@emdneto
emdneto marked this pull request as ready for review March 18, 2026 00:40
@emdneto
emdneto requested a review from a team as a code owner March 18, 2026 00:40
@emdneto emdneto changed the title introduce alls-green for required checks introduce alls-green action for required checks Mar 18, 2026
@emdneto emdneto moved this to Ready for review in Python PR digest Mar 18, 2026
emdneto added 2 commits March 17, 2026 21:51
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
@emdneto emdneto added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Mar 18, 2026
Comment thread .github/workflows/generate_workflows.py

@tammy-baylis-swi tammy-baylis-swi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm new to this tool but I think this is helpful for upkeep while keeping contributing instructions the same and retaining what I'm used to checking on PRs, e.g. this failed test still has the full error printed and failed jobs can still individually be retried.

Comment thread tox.ini Outdated
Comment thread .github/workflows/templates/ci.yml.j2 Outdated
Comment thread .github/workflows/ci.yml Outdated
emdneto and others added 2 commits April 3, 2026 14:02
Co-authored-by: Emídio Neto <9735060+emdneto@users.noreply.github.com>
@xrmx
xrmx merged commit 8783a58 into open-telemetry:main Apr 3, 2026
509 checks passed
@github-project-automation github-project-automation Bot moved this from Ready for review to Done in Python PR digest Apr 3, 2026
Vitexus pushed a commit to Vitexus/python-opentelemetry-proto that referenced this pull request Apr 30, 2026
* try alls-green for required checks

Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>

* ci

* add contrib_0

Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>

* test without allowed skips

Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>

* simulate failure in public-symbols-check

Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>

* empty commit to trigger ci -- added skip label -- ci check should pass

* test single files

Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>

* remove test_1.yml

Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>

* update test.yml

Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>

* test allowed-failures by job name

Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>

* show alls-green check fails if one of the required jobs fail

Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>

* remove uneeded files

Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>

* cleanup

Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>

* update README.md

Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>

* Apply suggestion from @xrmx

* Apply suggestions from code review

Co-authored-by: Emídio Neto <9735060+emdneto@users.noreply.github.com>

---------

Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
Co-authored-by: Leighton Chen <lechen@microsoft.com>
Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants