Repository navigation
introduce alls-green action for required checks - #4988
Merged
Merged
Conversation
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
emdneto
commented
Mar 18, 2026
emdneto
marked this pull request as ready for review
March 18, 2026 00:40
alls-green action for required checks
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
xrmx
reviewed
Mar 18, 2026
tammy-baylis-swi
approved these changes
Mar 31, 2026
tammy-baylis-swi
left a comment
Contributor
There was a problem hiding this comment.
I'm new to this tool but I think this is helpful for upkeep while keeping contributing instructions the same and retaining what I'm used to checking on PRs, e.g. this failed test still has the full error printed and failed jobs can still individually be retried.
herin049
approved these changes
Apr 1, 2026
xrmx
approved these changes
Apr 2, 2026
xrmx
reviewed
Apr 2, 2026
emdneto
commented
Apr 3, 2026
Co-authored-by: Emídio Neto <9735060+emdneto@users.noreply.github.com>
Vitexus
pushed a commit
to Vitexus/python-opentelemetry-proto
that referenced
this pull request
Apr 30, 2026
* try alls-green for required checks Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com> * ci * add contrib_0 Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com> * test without allowed skips Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com> * simulate failure in public-symbols-check Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com> * empty commit to trigger ci -- added skip label -- ci check should pass * test single files Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com> * remove test_1.yml Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com> * update test.yml Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com> * test allowed-failures by job name Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com> * show alls-green check fails if one of the required jobs fail Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com> * remove uneeded files Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com> * cleanup Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com> * update README.md Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com> * Apply suggestion from @xrmx * Apply suggestions from code review Co-authored-by: Emídio Neto <9735060+emdneto@users.noreply.github.com> --------- Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com> Co-authored-by: Leighton Chen <lechen@microsoft.com> Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
All required CI checks are currently managed through Terraform in the admin repo, which makes it difficult to meet our
tox -e generate-workflowsapproach. In some cases, it's hard to coordinate the Terraform update on the admin repo + updating our CI here.We discussed internally on Slack about
alls-greento remove that maintenance overhead and avoid requiring admin-repo Terraform updates whenever the required checks change.I did some tests, when a job is skipped, the
alls-greencheck respects that and skips the job as well during the check.Important things to consider:
Changes
Before merge
CI / checkas required in Github -- this is the only one needed.