Skip to content

test-util: allow filtering metrics by scope #4883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xrmx merged 2 commits into from
Jan 23, 2026
Merged

test-util: allow filtering metrics by scope #4883

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a3a343
test-util: allow filtering metrics by scope
anuraaga Jan 23, 2026
9d9abe1
Apply suggestions from code review
xrmx Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion tests/opentelemetry-test-utils/src/opentelemetry/test/test_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,13 @@ def disable_logging(highest_level=logging.CRITICAL):
finally:
logging.disable(logging.NOTSET)

def get_sorted_metrics(self):
def get_sorted_metrics(self, scope: Optional[str] = None):
"""Returns recorded metrics sorted by name.

Args:
scope: Optional scope name to filter metrics by. If unset,
all metrics are returned.
"""
metrics_data = self.memory_metrics_reader.get_metrics_data()
resource_metrics = (
metrics_data.resource_metrics if metrics_data else []
Expand All @@ -151,6 +157,8 @@ def get_sorted_metrics(self):
all_metrics = []
for metrics in resource_metrics:
for scope_metrics in metrics.scope_metrics:
if scope is not None and scope_metrics.scope.name != scope:
continue
all_metrics.extend(scope_metrics.metrics)

return self.sorted_metrics(all_metrics)
Expand Down
Loading