opentelemetry-sdk: make it possible to customize processors configuation #4806
+58
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion Make it easier for distributions to override the processors set up by the sdk configurator by specifying a span processor and a log record processor.
xrmx
commented
Nov 12, 2025
| exporter_args = exporter_args_map.get(exporter_class, {}) | ||
| provider.add_span_processor( | ||
| BatchSpanProcessor(exporter_class(**exporter_args)) | ||
| span_processor(exporter_class(**exporter_args)) |
Contributor
Author
There was a problem hiding this comment.
This is failing pyright check because Type[SpanProcessor] does not impose a constructor that takes an exporter as first parameter. Need to type that I guess.
xrmx
commented
Nov 12, 2025
| id_generator: IdGenerator | None = None, | ||
| setup_logging_handler: bool | None = None, | ||
| exporter_args_map: ExporterArgsMap | None = None, | ||
| span_processor: Type[SpanProcessor] | None = None, |
Contributor
Author
There was a problem hiding this comment.
This is the same for every exporter, is it enough or we want to make it per exporter?
There was a problem hiding this comment.
This might make the API too ugly, but we could do
span_processors: dict[str, Type[SpanProcessor] | None = None,
default_span_processor: Type[SpanProcessor] | None = None
Contributor
Author
There was a problem hiding this comment.
With the current code we call just one processor wrapping the exporter class, what I was asking if people with multiple exporters may want to use a different processor depending on the exporter, similar on how we handle the exporters args as exporter_args_map.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make it easier for distributions to override the processors set up by the sdk configurator by specifying a span processor and a log record processor.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Contrib Repo Change?
Checklist: