feat: add opentelemetry-instrumentation-oracledb package - #4989
Open
herin049 wants to merge 3 commits into
Open
Conversation
Pull request dashboard statusWaiting on reviewers · refreshed 2026-08-24 01:45 UTC Review the latest changes. Status above doesn't look right?
|
pmcollins
reviewed
Aug 24, 2026
pmcollins
left a comment
Member
There was a problem hiding this comment.
Thanks for doing this. LGTM but for one use case.
|
|
||
| def __getattr__(self, name: str) -> Any: | ||
| return getattr(self.__wrapped__, name) | ||
|
|
Member
There was a problem hiding this comment.
I integration tested this instrumentation locally against an Oracle db, and everything I tested worked fine except for using with instead of async with on an async cursor. This works without instrumentation but with an instrumented cursor raises a type error:
async def use_cursor_context_manager() -> None:
async with oracledb.connect_async(...) as connection:
with connection.cursor():
pass
asyncio.run(use_cursor_context_manager())
Looks like adding support for synchronous __enter__ and __exit__ here should fix it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support for instrumenting the OracleDB Python client. This package is being relocated from herin049/opentelemetry-instrumentation-oracledb
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.