redis: emit db.namespace for database index - #4988
Conversation
Assisted-by: Codex
f1f19f2 to
9ed14d5
Compare
Pull request dashboard statusWaiting on the author · refreshed 2026-08-22 21:43 UTC Move out of draft to request review. Status above doesn't look right?
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f1f19f2736
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| self.assertIn(DB_NAMESPACE, span.attributes) | ||
| self.assertEqual(span.attributes[DB_NAMESPACE], "0") |
There was a problem hiding this comment.
When stable database semantic conventions are used through async Redis clients or async pipelines, this helper also emits db.namespace, but the added assertions exercise only the synchronous client; the existing async stable/dup tests do not verify the new attribute. Add corresponding DB_NAMESPACE name and string-value assertions for the async variants so both public APIs are guarded.
AGENTS.md reference: AGENTS.md:L94-L96
Useful? React with 👍 / 👎.
| self.assertIn(DB_NAMESPACE, span.attributes) | ||
| self.assertEqual(span.attributes[DB_NAMESPACE], "0") |
There was a problem hiding this comment.
These assertions run through test-requirements.txt, which pins only redis==5.0.1, and the Redis tox environments have no oldest/latest factors, even though the package supports redis >=2.6. Add oldest/latest requirement sets and tox factors so the new namespace behavior is validated at both supported dependency boundaries.
AGENTS.md reference: AGENTS.md:L97-L98
Useful? React with 👍 / 👎.
1 participant
Description
Emit
db.namespacefor the Redis database index when stable database semantic conventions are enabled. Indatabase/dupmode, retain the legacy integer attribute and emit the stable string attribute.Fixes #4986
Type of change
How Has This Been Tested?
67 passed)4 passed)Does This PR Require a Core Repo Change?
Checklist: