Skip to content

Fix Azure detector example typo - #4984

Open
tammy-baylis-swi wants to merge 1 commit into
open-telemetry:mainfrom
tammy-baylis-swi:fix-typo
Open

Fix Azure detector example typo#4984
tammy-baylis-swi wants to merge 1 commit into
open-telemetry:mainfrom
tammy-baylis-swi:fix-typo

Conversation

@tammy-baylis-swi

Copy link
Copy Markdown
Contributor

Description

Fixes incorrect import typo in Azure Resource Detector example. It's covered by the next line.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Followed the example in my own setup.

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@tammy-baylis-swi tammy-baylis-swi added documentation Improvements or additions to documentation Skip Changelog PRs that do not require a CHANGELOG.md entry labels Aug 21, 2026
@tammy-baylis-swi
tammy-baylis-swi requested a lite review from Copilot August 21, 2026 18:58
@tammy-baylis-swi
tammy-baylis-swi marked this pull request as ready for review August 21, 2026 18:59
@tammy-baylis-swi
tammy-baylis-swi requested a review from a team as a code owner August 21, 2026 18:59

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes the usage example in the Azure Resource Detector README by removing an incorrect/duplicate import so the example matches the actual module where AzureVMResourceDetector is defined.

Changes:

  • Removed the erroneous AzureVMResourceDetector import from the azure.app_service import block in the README example.
  • Leaves AzureVMResourceDetector imported solely from opentelemetry.resource.detector.azure.vm, aligning the example with the implementation.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@opentelemetry-pr-dashboard

opentelemetry-pr-dashboard Bot commented Aug 21, 2026

Copy link
Copy Markdown

Pull request dashboard status

Waiting on maintainers · refreshed 2026-08-24 18:34 UTC

Merge when ready.

Status above doesn't look right?
  • Just replied or pushed? Anything around or after the refresh time above may not be picked up yet — give it a few minutes.
  • Anything look wrong? Report it with what you expected; it helps us improve the dashboard.

@tammy-baylis-swi tammy-baylis-swi moved this to Easy to review / merge / close in Python PR digest Aug 21, 2026
@github-project-automation github-project-automation Bot moved this from Easy to review / merge / close to Approved PRs in Python PR digest Aug 24, 2026
@lzchen
lzchen added this pull request to the merge queue Aug 24, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Aug 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

Status: Approved PRs

Development

Successfully merging this pull request may close these issues.

4 participants