Skip to content

Fix precommit failure from unformatted aio-pika instrumentation test - #4983

Draft
lzchen with Copilot wants to merge 22 commits into
mainfrom
copilot/fix-precommit-job
Draft

Fix precommit failure from unformatted aio-pika instrumentation test#4983
lzchen with Copilot wants to merge 22 commits into
mainfrom
copilot/fix-precommit-job

Conversation

Copilot AI commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Description

The misc / precommit job failed because pre-commit run --all-files had both ruff hooks modify files, which fails the run.

Offending file: instrumentation/opentelemetry-instrumentation-aio-pika/tests/test_aio_pika_instrumentation.py

  • ruff (lint): 1 × W293 (blank line containing whitespace)
  • ruff format: unnecessary line wrapping (repo line-length = 120) plus a trailing blank line

Changes

  • Applied ruff 0.16.0 (the version pinned in .pre-commit-config.yaml) --fix and ruff format to the affected test file. Whitespace/formatting only — no test logic changed.
  • Merged the PR head branch (hardcode-instrumentation-name-4173) into this branch, since this branch was cut from main and did not contain the file that triggers the failure.
-            AioPikaInstrumentor().instrument(
-                tracer_provider=self.tracer_provider
-            )
+            AioPikaInstrumentor().instrument(tracer_provider=self.tracer_provider)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • ruff check . → all checks passed
  • ruff format --check . → 826 files already formatted

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

Copilot AI and others added 2 commits August 21, 2026 15:01
Co-authored-by: lzchen <11580155+lzchen@users.noreply.github.com>
Co-authored-by: lzchen <11580155+lzchen@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix failing GitHub Actions job 'misc / precommit' Fix precommit failure from unformatted aio-pika instrumentation test Aug 21, 2026
Copilot AI requested a review from lzchen August 21, 2026 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants