Skip to content

opentelemetry-util-http: preserve redacted query args - #4960

Open
jstar0 wants to merge 2 commits into
open-telemetry:mainfrom
jstar0:fix/http-redact-query-preserve-blanks
Open

opentelemetry-util-http: preserve redacted query args#4960
jstar0 wants to merge 2 commits into
open-telemetry:mainfrom
jstar0:fix/http-redact-query-preserve-blanks

Conversation

@jstar0

@jstar0 jstar0 commented Aug 15, 2026

Copy link
Copy Markdown

Description

Preserve blank query-argument values when redact_query_parameters is enabled in opentelemetry-util-http.

Fixes: none

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • uv run --active env PYTHONPATH=src pytest tests/test_redact_query_parameters.py -q

Does This PR Require a Core Repo Change?

  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added

@jstar0
jstar0 requested a review from a team as a code owner August 15, 2026 00:51
@linux-foundation-easycla

linux-foundation-easycla Bot commented Aug 15, 2026

Copy link
Copy Markdown

CLA Not Signed

@opentelemetry-pr-dashboard

opentelemetry-pr-dashboard Bot commented Aug 15, 2026

Copy link
Copy Markdown

Pull request dashboard status

Waiting on the author · refreshed 2026-08-22 01:44 UTC

Two things need attention:

  • Required checks are failing — investigate the failures.
  • 1 review item — respond to each (e.g. link a commit, explain why not, ask a follow-up):
    • Top-level threads: 1
Status above doesn't look right?
  • Just replied or pushed? Anything around or after the refresh time above may not be picked up yet — give it a few minutes.
  • Should this be with reviewers? Comment /dashboard route:reviewers to route it to them.
  • Anything wrong — including the routing? Report it with what you expected; it helps us improve the dashboard.

@xrmx

xrmx commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

@jstar0 thanks for the PR but we need you to sign the CLA in order to contribute to this repository.

@xrmx xrmx moved this to Reviewed PRs that need fixes in Python PR digest Aug 17, 2026
@opentelemetry-pr-dashboard

Copy link
Copy Markdown

Hi @jstar0 — just a friendly reminder that this pull request is waiting on you. The dashboard status comment has the open items and is kept current.

  • Replying is enough to hand it off — answer, explain why no change is needed, or ask a follow-up. The dashboard routes it onward once nothing on the list is waiting on you.
  • To hand it back for any other reason, including the dashboard getting this wrong, comment /dashboard route:reviewers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Reviewed PRs that need fixes

Development

Successfully merging this pull request may close these issues.

2 participants