opentelemetry-instrumentation-django: remove duplicate calls#4771
Draft
codeboten wants to merge 1 commit into
Draft
opentelemetry-instrumentation-django: remove duplicate calls#4771codeboten wants to merge 1 commit into
codeboten wants to merge 1 commit into
Conversation
The django instrumentation made multiple calls to the same method, storing the results on the first call instead. Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The django instrumentation made multiple calls to the same method, storing the results on the first call instead.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Added benchmark test
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.