opentelemetry-instrumentation-aiohttp-server: fix span name and http.route attribute according to semconv#4768
Open
xrmx wants to merge 2 commits into
Open
Conversation
… according to semconv Do the method sanitization in the span name and use the canonical path also for http.route instead of the handler name.
xrmx
changed the title
xrmx
commented
Jul 2, 2026
| base_url=f"http://{server.host}:{server.port}" | ||
| ) | ||
| # the client is strict about the HTTP methods, for some reason | ||
| # QUERY is fine for the client but unrecognized by the server |
Contributor
Author
There was a problem hiding this comment.
It looks like this isn't true on Pypy 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Do the method sanitization in the span name and use the canonical path also for http.route instead of the handler name.
Fixes #3222
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.