fix(logging): export formatter-added attributes#4764
Open
pmcollins wants to merge 3 commits into
Open
Conversation
JWinermaSplunk
approved these changes
Jun 30, 2026
herin049
approved these changes
Jul 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some logging formatters, such as Celery’s, add fields to the passed-in LogRecord during formatting. OTel’s LoggingHandler currently collects attributes before calling the formatter, so formatter-added fields are omitted from exported logs.
This change collects attributes after formatting the record so that formatter-added fields are exported by OTel Python.
Fixes open-telemetry/opentelemetry-python#4446
Type of change
How Has This Been Tested?
tox -e py314-test-instrumentation-logging— 66 tests passedtest_formatter_added_attributes_are_exported, which verifies an attribute added byFormatter.format()is included in the exported log recordTaskFormatterand verified thattask_idandtask_nameare exported as structured log attributesDoes This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.