Fix duplicate Pyramid traversal subscribers#4741
Open
sjh9714 wants to merge 1 commit into
Open
Conversation
|
|
Register Pyramid traversal callbacks only once per configurator settings so a commit during include processing does not allow later includes to add duplicate subscribers. Assisted-by: OpenAI Codex
sjh9714
force-pushed
the
fix-pyramid-duplicate-before-traversal
branch
from
c9112a4 to
035853c
Compare
Author
|
/easycla |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4663.
opentelemetry-instrumentation-pyramidcan register duplicate_before_traversalsubscribers when a Pyramid include callsconfig.commit()and a later include creates another child configurator. This change records that the callbacks have already been registered in Pyramid settings, so later includes re-enable tracing without adding a duplicate subscriber or tween.Type of change
How Has This Been Tested?
uvx --from tox --with tox-uv tox -e py314-test-instrumentation-pyramiduvx --from tox --with tox-uv tox -e lint-instrumentation-pyramiduvx --from tox --with tox-uv tox -e ruffDoes This PR Require a Core Repo Change?
Checklist: