opentelemetry-instrumentation-pymemcache: add semconv stability migration support#4739
Open
SurbhiD404 wants to merge 7 commits into
Open
opentelemetry-instrumentation-pymemcache: add semconv stability migration support#4739SurbhiD404 wants to merge 7 commits into
SurbhiD404 wants to merge 7 commits into
Conversation
xrmx
requested changes
Jun 26, 2026
xrmx
left a comment
Contributor
There was a problem hiding this comment.
Same comment of the cassandra PR about leveraging _semconv _set_db_* helpers plus _set_net_* and _set_http_* ones as well.
Please does not open more than one PR at a time, wait to get approval from one so you can apply what you learned in the process.
f095c62 to
4c7f584
Compare
xrmx
reviewed
Jul 1, 2026
xrmx
requested changes
Jul 1, 2026
xrmx
reviewed
Jul 1, 2026
0d40de7 to
6bb1073
Compare
xrmx
approved these changes
Jul 3, 2026
…tion support Signed-off-by: Surbhi Dharvan <dharvansurbhi@gmail.com>
Signed-off-by: Surbhi Dharvan <dharvansurbhi@gmail.com>
Signed-off-by: Surbhi Dharvan <dharvansurbhi@gmail.com>
Signed-off-by: Surbhi Dharvan <dharvansurbhi@gmail.com>
Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
…comment Signed-off-by: Surbhi Dharvan <dharvansurbhi@gmail.com>
Signed-off-by: Surbhi Dharvan <dharvansurbhi@gmail.com>
18e704f to
c915484
Compare
emdneto
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements semantic convention stability migration support for the
pymemcacheinstrumentation, as tracked in #2453.Previously,
PymemcacheInstrumentoremitted legacy (incubating) database semantic convention attributes unconditionally. This change adds opt-in support for the new stable database semantic convention attributes, controlled by theOTEL_SEMCONV_STABILITY_OPT_INenvironment variable.Attribute mapping
databasemode)db.systemdb.system.namedb.statementdb.query.textnet.peer.nameserver.addressnet.peer.portserver.portnet.transportFixes #4715
Part of #2453
Type of change
How Has This Been Tested?
Three unit tests were added covering all three semconv modes:
OTEL_SEMCONV_STABILITY_OPT_IN=database: verifies stable attributes are present and legacy attributes are absent.OTEL_SEMCONV_STABILITY_OPT_IN=database/dup: verifies both legacy and stable attributes are emitted simultaneously.To reproduce:
cd instrumentation/opentelemetry-instrumentation-pymemcache python -m pytest tests/test_pymemcache.py -vResult:
Does This PR Require a Core Repo Change?
Checklist