Skip to content

Conversation

@anuraaga
Copy link
Contributor

Description

I am helping implement SDK metrics in open-telemetry/opentelemetry-python#4880. By nature of their definition, they are present by usage of the SDK itself, meaning the metrics are populated in instrumentation tests too. Unfortunately, many instrumentation tests have strict checks on generated metrics so extra metrics cause them to fail.

@xrmx suggested we can try adding filtering in TestBase, and using TestBase more instead of doing management in unit tests simplifies them anyways, so I am helping with these migrations. Here we can simply replace all locations with using the helper for a general cleanup.

As it's testing infrastructure only, this PR should be skip-changelog.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Unit tests

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@xrmx xrmx added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jan 23, 2026
@xrmx xrmx enabled auto-merge (squash) January 23, 2026 11:42
@xrmx xrmx merged commit b960b38 into open-telemetry:main Jan 23, 2026
663 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants